search

HR10Knights / ShowPlots

4 stars 3 forks source link

(enhance) add ability to suggest shows with same name #32

Open ZacharyRSmith opened 9 years ago

ZacharyRSmith commented 9 years ago

Eg, try searching "sopranos"...you get 2 instances of "The Sopranos" which seem the same inasmuch as they render the same on the graph (i haven't looked at the actual JS objects yet...)

ZacharyRSmith commented 9 years ago

another example: "The Office"

ZacharyRSmith commented 9 years ago

44 fixed "The Sopranos", but NOT "The Office"

ZacharyRSmith commented 9 years ago

Ok, still showing 2 suggestions for "The Office" because it's showing the US and UK versions. However, whichever the end-user clicks on, the US version is shown because we're just using the show name to get graph data

...possible solution is:

// checking search suggestions for duplicates // if dup // make API call using OMDB to get IMDB id (refactor getAllSeasons() to use id instead of title)

...the above would take some time, so I'll be doing a patch that just excludes shows with duplicate names

ZacharyRSmith commented 9 years ago

51 patches this, but should be improved