search

HSU-HPC / MaMiCo

The macro-micro-coupling tool for coupled molecular-continuum flow simulation
BSD 3-Clause "New" or "Revised" License
13 stars 5 forks source link

Config files may have root XML node: <mamico-configuration> #49

Closed rubenhorn closed 7 months ago

rubenhorn commented 7 months ago

Closes #48

rubenhorn commented 7 months ago 
* I find the chosen name of the root XML node `<mamico-configuration>` very very confusing... Because we already have the class `MaMiCoConfiguration` and lots of variables are named like `_mamicoConfig` etc. But now you are telling us that `<mamico-configuration>` IS NOT A `MaMiCoConfiguration` ..., really? Especially also since `molecular-dynamics` config is not a part of mamico, from mamico's perspective. I think we should choose a better name here. E.g. `<simulation-configuration>` or `<scenario-configuration>` fits much better IMO.

There is already a simulation-configuration node in the MD part of the configuration files, so we should go with scenario-configuration.