search

HTBox / allReady

This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.
http://www.htbox.org/projects/allready
MIT License
891 stars 624 forks source link

Gulp 3.9.1 Issues with Node 10 #2346

Open oneolddev opened 5 years ago

oneolddev commented 5 years ago

I got everything to build after fixing #2344 and #2345 but the website did not render correctly. image There were no build errors. Finally spotted image indicating that not all the npm dependencies were being installed. Manually restoring resulted in image

oneolddev commented 5 years ago

It turns out this is related to Dependency of Gulp 3.9.1 causes error in Node 10.

I applied the fix as suggested in the link above to resolve. This appeared to have work but did get the following image

The web pages appear to be rendering correctly but I am unsure about the 15 vulnerabilities reported.

djonphillips commented 5 years ago

I am experiencing a similar issue with node v10.15.1. The Website does not render correctly and the Visual Studio Task Runner Explorer reports that Gulpfile.js failed to load and the following information was in the output window: Failed to run "C:\Users\Phillips' PC\source\repos\allReady\AllReadyApp\Web-App\AllReady\Gulpfile.js"... cmd.exe /c gulp --tasks-simple gulp --tasks-simple[664]: src\node_contextify.cc:633: Assertion `args[1]->IsString()' failed. 1: 00007FF6C6760EFA v8::internal::GCIdleTimeHandler::GCIdleTimeHandler+4810 2: 00007FF6C673A296 node::MakeCallback+4518 3: 00007FF6C673A34F node::MakeCallback+4703 4: 00007FF6C670D5E8 node::DecodeWrite+12952 5: 00007FF6C6F6ADD2 v8::internal::OptimizingCompileDispatcher::Unblock+60562 6: 00007FF6C6F6BF58 v8::internal::OptimizingCompileDispatcher::Unblock+65048 7: 00007FF6C6F6B28D v8::internal::OptimizingCompileDispatcher::Unblock+61773 8: 00007FF6C6F6B1AB v8::internal::OptimizingCompileDispatcher::Unblock+61547 9: 0000035C0DB5C5C1

oneolddev commented 5 years ago

Did some investigation of the AppVeyor build server since this error message did not appear there - see #2351. The build server is using Node 8.15.

Installing Node 8.15 solved this problem - installed https://nodejs.org/download/release/v8.15.0/node-v8.15.0-x64.msi.

In order to ensure that Node 8.15 was being used instead of the Node 10 installed with VS2017 15.9.* the path to the Node 8.15 installation needs to added under the External Web Tools options.

image

oneolddev commented 5 years ago

Did some future proofing to support Gulp 4 in PR #2352 which works in both Node 10 and Node 8.15.

Removed knockout-bootstrap - including cause the integration test to fail intermittently. This needs to be researched further.