Avoid resolving view when retrieving the previous compiler

HTMLMin / Laravel-HTMLMin

A simple HTML minifier for Laravel 5, 6, 7, 8 & 9.

MIT License

1.02k stars 119 forks source link

Avoid resolving view when retrieving the previous compiler #162

Closed xel1045 closed 2 years ago

xel1045 commented 3 years ago

When registering htmlmin.compiler, the view class is resolved which is not supposed to happen in the register. This behaviour may breaks other plugins that except view to be registered later.

This PR use the callAfterResolving to retrieve the old compiler when view is resolved.

xel1045 commented 3 years ago

The same environments seems to be broken on the master branch: https://travis-ci.org/github/HTMLMin/Laravel-HTMLMin/builds/773310940

u01jmg3 commented 2 years ago

@srmklive: can we get this merged too? After a rebase, the tests should pass.

srmklive commented 2 years ago

Merged.

rcerljenko commented 2 years ago

hi @srmklive are you planning to release a new version with this fix?