HUJI-Deep / simnets-tf

SimNets implementation in TensorFlow
MIT License
7 stars 3 forks source link

Wrong MEX dimension calculation for unshared offsets with negative values #11

Closed orsharir closed 7 years ago

orsharir commented 7 years ago

I've just noticed that you've got a minor bug (starting at this line)[https://github.com/HUJI-Deep/simnets-tf/blob/559663bf60a647f232e81adc3692c40cf473d661/src/mex_kernel_common.cpp#L98]. Instead of 1 it should be equal to the respective dimension.