HUJI-Deep / simnets-tf

SimNets implementation in TensorFlow
MIT License
7 stars 3 forks source link

Add unit tests for shape sizes and for correctly setting parameters #15

Open orsharir opened 7 years ago

orsharir commented 7 years ago

Given the cause of issue #8, I suggest you add unit tests for correct setting of input parameters and shapes. E.g. check that when you set unshared/shared weights the parameters size is correct -- do not use the functions you've written to handle this, but instead have hard coded values for a few cases. Do the same for other parameters (block, pooling, etc.).