HUJI-Deep / simnets-tf

SimNets implementation in TensorFlow
MIT License
7 stars 3 forks source link

Refactor ggemm_cpu.hpp #19

Closed orsharir closed 7 years ago

orsharir commented 7 years ago

I've just noticed that you've put a lot of extra functions in ggemm_cpu.hpp which have nothing to do with it, e.g. the special ops used by certain layers or the split_patches function. Please put each of these functions in separate logical header instead. E.g. all the mex related functions in a mex_shared_utils.hpp, etc.