search

HabitRPG / habitica-chat-extension

A habitica.com Chat Client for Chrome
18 stars 13 forks source link

"Enter" does not send the message #52

Closed JohnJSal closed 4 years ago

JohnJSal commented 4 years ago

According to the Wiki page, Enter sends the message and Shift+Enter inserts new lines, but both combinations are inserting new lines for me. The only way to send the message is to manually click the "Send" button. Should Enter be sending messages?

benjaminbhollon commented 4 years ago

Yeah, we made an update where Ctrl+Enter is the only keystroke that sends messages, just like on the website. The wiki probably needs to be updated.

JohnJSal commented 4 years ago

Thanks for the quick reply! I'll update the wiki as soon as I have a chance!

Take care! John

On Sat, Nov 2, 2019, 1:40 AM Benjamin notifications@github.com wrote:

Yeah, we made an update where Ctrl+Enter is the only keystroke that sends messages, just like on the website. The wiki probably needs to be updated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica-chat-extension/issues/52?email_source=notifications&email_token=ANU7DIAZQGU7LIGWO5GRYQ3QRUOEJA5CNFSM4JIA5QA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4VFXQ#issuecomment-549016286, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANU7DIG7457EDD3U4CKXFY3QRUOEJANCNFSM4JIA5QAQ .

JohnJSal commented 4 years ago

Hi again. Just wanted to mention that I tried Ctrl+Enter but it didn't work. Nothing happened when I pressed them.

On Sat, Nov 2, 2019 at 10:20 AM John Salerno johnjsal@gmail.com wrote:

Thanks for the quick reply! I'll update the wiki as soon as I have a chance!

Take care! John

On Sat, Nov 2, 2019, 1:40 AM Benjamin notifications@github.com wrote:

Yeah, we made an update where Ctrl+Enter is the only keystroke that sends messages, just like on the website. The wiki probably needs to be updated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica-chat-extension/issues/52?email_source=notifications&email_token=ANU7DIAZQGU7LIGWO5GRYQ3QRUOEJA5CNFSM4JIA5QA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4VFXQ#issuecomment-549016286, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANU7DIG7457EDD3U4CKXFY3QRUOEJANCNFSM4JIA5QAQ .

benjaminbhollon commented 4 years ago

Hmm... Maybe that part of the update hasn't been released yet? I'll check on it.

benjaminbhollon commented 4 years ago

Ah, commit 299fe7f hasn't been released yet because it conflicted with something else. I'll get to work on that within the next few days.

JohnJSal commented 4 years ago

Ok, thanks again for the quick replies! Take care!

On Sun, Nov 3, 2019 at 2:15 AM Benjamin notifications@github.com wrote:

Ah, commit 299fe7f https://github.com/HabitRPG/habitica-chat-extension/commit/299fe7f026834f9b449ca4fe1edf4d18aedda757 hasn't been released yet because it conflicted with something else. I'll get to work on that within the next few days.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica-chat-extension/issues/52?email_source=notifications&email_token=ANU7DICYDJXPVAWWUQLC2ETQR2CBTA5CNFSM4JIA5QA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC5NFYA#issuecomment-549114592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANU7DIDGJN3YUXBUER3U7ETQR2CBTANCNFSM4JIA5QAQ .

Alys commented 4 years ago

I'm closing this because the Ctrl-Enter feature was implemented in https://github.com/HabitRPG/habitica-chat-extension/commit/299fe7f026834f9b449ca4fe1edf4d18aedda757

Note though that there's a new(?) bug which causes it and other features to fail, documented at https://github.com/HabitRPG/habitica-chat-extension/issues/55