HabitRPG / habitica-ios

Native iOS app for Habitica
GNU General Public License v3.0
712 stars 234 forks source link

Redirection to web browser without connectivity check in the 'About' section #1296

Closed JPRamirez17 closed 4 months ago

JPRamirez17 commented 1 year ago

Describe the bug When the user goes to the ‘About’ section and taps on any of the links for making reviews, sharing an opinion, knowing the source code, social media or going to the official website of the app, it is redirected to the web browser without checking Internet connection. This issue corresponds to the redirection without connectivity check (RWPC) Eventual Connectivity anti-pattern, in which the user never knows if there is an Internet connection and shows a blank web page. In this case, redirecting to the web browser without Internet connection might make the user think that simply there is no content in that section or even annoy the user because it loses some seconds in that useless action.

To Reproduce Steps to reproduce the behavior:

  1. Access the ‘About’ view and click any link without internet connection
  2. User is redirected to the web browser without notifying that connectivity is not available

Expected behavior Do not redirect the user to the web browser without internet connection. Instead, it should notify the user that redirection is not possible due to lack of connectivity.

Screenshots

Screenshot 2023-05-17 alle 9 11 41 PM

Smartphone (please complete the following information):

saraolson commented 4 months ago

We've vastly improved server response time that should make it so this isn't encountered through normal use of the app much at all. Closing this issue, though if we receive player reports we can re-evaluate.