HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
12.04k stars 4.1k forks source link

Emoji library is out of date and needs overhaul/replacement #12741

Open SabreCat opened 4 years ago

SabreCat commented 4 years ago

Description

Habitica uses its own emoji library within its Markdown implementation. We parse strings like :smiley_cat: into image paths pointing to a collection of emoji stored on Amazon S3, which in turn come from this collection plus a few custom creations of our own.

All of these are wildly out of date vs. current emoji standards, and thus, users' expectations of how emoji should work and which ones are supported! Thus issue reports like #9128, requesting support for missing emoji; and #10927, where an attempted workaround by pasting raw UTF emoji confuses the module and leads to more broken image links.

Habitica's emoji handling needs an upgrade. Ideally, the solution should:

This will require team and design input--choosing an image set for display, selecting disallowed emoji, etc.

citrusella commented 4 years ago

This might be better suited somewhere else but I figured I would ask it here since it's vaguely related to/questioning something one of the bullet points:

Is the third one (the disallowing) already supposed to be happening with some emoji (the way the custom emoji like melior in the previous bullet are already happening)? Or is it just desired whenever this happens? Because the middle finger emoji used as an example currently works on Habitica via both replacement of the Unicode version and via a specific but offensive :code: (viewable (commented out) in the source code of this section of a subpage of my userpage on the wiki where I compiled all working emoji alt text) and I had been meaning to report that because it seemed unintended (probably through email because it seems like a bad idea to say "you can post middle fingers" right out in the open of the bug guild).

SabreCat commented 4 years ago

@citrusella: Nope, that's a wishlist item that I think the eventual solution should consider, not something we currently have going!

JeppeKlitgaard commented 2 years ago

Is there any update on this? In my view this is quite an important feature that is missing.

It might be worthwhile to add that Unicode emoji's currently have working behaviour in some places:

ofilipowicz commented 2 years ago

To be honest, I think it should be split into two tasks. One is fixing current emojis which have not been working since many, many years already. Two is designing more emojis as mentioned by @SabreCat.

Ticket no. 1 wouldn't require design team work and could be easily done by one developer. This way, we would at least have basic emojis working. Otherwise, we can wait for resources to do all design work indefinitely 😉

citrusella commented 2 years ago

I'm sure this is just me with a no-reading-comprehension-today brain, but when you say "fixing current emoji" do you mean "upgrading the library to a current standard" or "making sure emoji that should theoretically be in the current, non-updated library are working"?

I feel like I'm sure you probably mean the first one but wanted to ask because I couldn't wrap my head around what it meant as written.

merwok commented 2 years ago

I read it as your first interpretation. First fix the emojis that exist now and work only partially, then do a broader rework or replacement of the whole library.

CuriousMagpie commented 2 years ago

I will be working closely with the rest of the team to determine the best approach for this issue. I know it's been a problem for a long time, but while this is something I am going to be working on, I am not actively working on it at this time.

dotMavriQ commented 1 year ago

Yeah, I used the "Stuffed Flatbread Emoji" for one of my Habits and it won't render properly in web browsers, so seemingly this is still an issue. 🥙

<img class="habitica-emoji" style="height: 1.5em; width: 1.5em" src="https://s3.amazonaws.com/habitica-assets/cdn/emoji/stuffed_flatbread.png" alt="stuffed_flatbread" draggable="false">

dospolov commented 1 year ago

I see that's still an issue

image

The icon set is pretty limited

image

Can I contribute somehow to the assets?

rilygreat commented 3 months ago

A new bug report from @Postiljon: Some emojis are not displayed correctly on the web application: jrjXrAV

They are displayed correctly when in Edit menu or on mobile.

luaralulu commented 2 months ago

I'm having same issue. Doesn't display on Task title on Web. Edit menu and mobile working fine.

Screenshot 2024-09-02 at 10 28 30
CuriousMagpie commented 2 months ago

As stated here, the team is aware of the issue. This is currently on hold. Thanks.

EDLLT commented 3 weeks ago

image Facing the same issue, hopefully it'd be fixed eventually