HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.84k stars 4.05k forks source link

Attribute tags in tasks need popovers #2044

Closed SabreCat closed 8 years ago

SabreCat commented 10 years ago

Win7 on Firefox, beta.habit, no console errors.

At present, mousing over one of the buttons to associate a task with an attribute doesn't display any additional information. There's even a ? bubble on Other, but it doesn't provide anything, whether the button is selected or unselected.

It would be great to have some brief suggestions or examples pop up on each of these, so users have a starting point for choosing which tasks get what.

edit by Alys:

This comment from Lemoness desccribes what we want to do for this issue:

Reading through this discussion again, it sounds like the consensus is to change the names of the attributes to reflect the stats. Let's do that. I'm happy with deilann's proposed text:

Strength: e.g. relating to exercise and activity Intelligence: e.g. relating to academic or mentally challenging pursuits Perception: e.g. relating to work, or financial tasks Constitution: e.g. relating to health, wellness, and social interaction

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

DanielTheBard commented 10 years ago

Agreed. Though for me, the ? bubble on other worked once I clicked on it. OS X Lion on Chrome.

The correlation between Physical, Social, Mental, Other and STR, CON, INT, PER should be made more apparent to the user. And as @SabreCat said, examples should be given of each.

SabreCat commented 10 years ago

Will fix this up in this branch.

deilann commented 10 years ago

@SabreCat Can this be closed?

SabreCat commented 10 years ago

@deilann: Alas, no. This is still one of my dangling tasks for that project (along with taskbased points backfill).

deilann commented 10 years ago

You can do it!

Alys commented 9 years ago

I'm unassigning SabreCat and adding the entry level coding tag. I'll advertise this in the Aspiring Coders guild when we've sorted out words.

To see the buttons that this issue discusses, you must go to your stats page and select "Automatic Allocation" then "Distribute points based on task activity", then edit any task and go into "Advanced Options". See screenshots below for the four buttons and the pop-over that shows when you hover on "Other".

@lemoness Would you like to suggest wording for the other three buttons?

screen shot 2015-05-18 at 6 51 27 am screen shot 2015-05-18 at 6 51 34 am

lemoness commented 9 years ago

Not totally sure they are necessary, but here's a quick stab at them -

Physical: "e.g. relating to health, wellness, and exercise." Mental: "e.g. relating to academic or mentally-challenging pursuits." Social: "e.g. relating to social interaction"

On Sun, May 17, 2015 at 1:53 PM, Alys notifications@github.com wrote:

I'm unassigning SabreCat and adding the entry level coding tag. I'll advertise this in the Aspiring Coders guild when we've sorted out words.

To see the buttons that this issue discusses, you must go to your stats page and select "Automatic Allocation" then "Distribute points based on task activity", then edit any task and go into "Advanced Options". See screenshots below for the four buttons and the pop-over that shows when you hover on "Other".

@lemoness https://github.com/lemoness Would you like to suggest wording for the other three buttons?

[image: screen shot 2015-05-18 at 6 51 27 am] https://cloud.githubusercontent.com/assets/1495809/7672126/8619d0ea-fd2a-11e4-8b6c-de3e1ba82761.png [image: screen shot 2015-05-18 at 6 51 34 am] https://cloud.githubusercontent.com/assets/1495809/7672127/8624db34-fd2a-11e4-87d5-594234f8604e.png

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-102856954.

deilann commented 9 years ago

They should also make clear what stat they are connected to because it really isn't obvious. Personally, I'd prefer we didn't proscribe which kind of tasks relate to which stats. It'd be better in my opinion for the buttons to be the stat it will go towards and the popover provide ideas as to what kind of tasks could go towards those stats.

So like:

Strength: e.g. relating to exercise and activity Intelligence: e.g. relating to academic or mentally challenging pursuits Perception: e.g. relating to work, or financial tasks Constitution: e.g. relating to health, wellness, and social interaction On May 17, 2015 11:28 PM, "lemoness" notifications@github.com wrote:

Not totally sure they are necessary, but here's a quick stab at them -

Physical: "e.g. relating to health, wellness, and exercise." Mental: "e.g. relating to academic or mentally-challenging pursuits." Social: "e.g. relating to social interaction"

On Sun, May 17, 2015 at 1:53 PM, Alys notifications@github.com wrote:

I'm unassigning SabreCat and adding the entry level coding tag. I'll advertise this in the Aspiring Coders guild when we've sorted out words.

To see the buttons that this issue discusses, you must go to your stats page and select "Automatic Allocation" then "Distribute points based on task activity", then edit any task and go into "Advanced Options". See screenshots below for the four buttons and the pop-over that shows when you hover on "Other".

@lemoness https://github.com/lemoness Would you like to suggest wording for the other three buttons?

[image: screen shot 2015-05-18 at 6 51 27 am] < https://cloud.githubusercontent.com/assets/1495809/7672126/8619d0ea-fd2a-11e4-8b6c-de3e1ba82761.png

[image: screen shot 2015-05-18 at 6 51 34 am] < https://cloud.githubusercontent.com/assets/1495809/7672127/8624db34-fd2a-11e4-87d5-594234f8604e.png

— Reply to this email directly or view it on GitHub <https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-102856954 .

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-102936559.

deilann commented 9 years ago

The reason I think this is because when I was using this system, it was very frustrating because for it to realistic work for me, I needed to completely work-over what the attributes "meant." With my health problems the divvies went something like this:

Strength: Cleaning and physical tasks, but not exercise. Intelligence: Mental tasks, learning, etc. Constitution: Meds, self-care, anything that would make me "damage resistant" Perception: Money related tasks, because PER gives you more drops and gold.

But that doesn't fit at all into "Physical" "Mental" "Social" "Other" and I think it's a little weird for Habit to proscribe what the tasks should be. Obviously, people can still use them for whatever they want, but it certainly felt weird to put my meds under "Social" and the weirdness made it more difficult to quickly sort tasks.

On Sun, May 17, 2015 at 11:43 PM, Ryan yandoryn@gmail.com wrote:

They should also make clear what stat they are connected to because it really isn't obvious. Personally, I'd prefer we didn't proscribe which kind of tasks relate to which stats. It'd be better in my opinion for the buttons to be the stat it will go towards and the popover provide ideas as to what kind of tasks could go towards those stats.

So like:

Strength: e.g. relating to exercise and activity Intelligence: e.g. relating to academic or mentally challenging pursuits Perception: e.g. relating to work, or financial tasks Constitution: e.g. relating to health, wellness, and social interaction On May 17, 2015 11:28 PM, "lemoness" notifications@github.com wrote:

Not totally sure they are necessary, but here's a quick stab at them -

Physical: "e.g. relating to health, wellness, and exercise." Mental: "e.g. relating to academic or mentally-challenging pursuits." Social: "e.g. relating to social interaction"

On Sun, May 17, 2015 at 1:53 PM, Alys notifications@github.com wrote:

I'm unassigning SabreCat and adding the entry level coding tag. I'll advertise this in the Aspiring Coders guild when we've sorted out words.

To see the buttons that this issue discusses, you must go to your stats page and select "Automatic Allocation" then "Distribute points based on task activity", then edit any task and go into "Advanced Options". See screenshots below for the four buttons and the pop-over that shows when you hover on "Other".

@lemoness https://github.com/lemoness Would you like to suggest wording for the other three buttons?

[image: screen shot 2015-05-18 at 6 51 27 am] < https://cloud.githubusercontent.com/assets/1495809/7672126/8619d0ea-fd2a-11e4-8b6c-de3e1ba82761.png

[image: screen shot 2015-05-18 at 6 51 34 am] < https://cloud.githubusercontent.com/assets/1495809/7672127/8624db34-fd2a-11e4-87d5-594234f8604e.png

— Reply to this email directly or view it on GitHub < https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-102856954>.

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-102936559 .

nicolevonvon commented 8 years ago

Hi, has this text been confirmed? It's the last task that hasn't been worked on in entry-level-coding and since I haven't worked in the environment yet I'd really like to tackle something basic before something more meaty...

Alys commented 8 years ago

@nicolevonvon It might be best to wait for final confirmation for this one, but you might like https://github.com/HabitRPG/habitrpg/issues/5979 which is ready to be worked on.

nicolevonvon commented 8 years ago

Thanks Alys will do so!

librarianmage commented 8 years ago

What is the current progress on this?

Alys commented 8 years ago

I think @deilann makes some good points about not overly specifying what they should be used for, and also about the need to state which attribute they affect.

Do we want to keep it as simple as this?

Physical: "Boosts your Strength attribute." Mental: "Boosts your Intelligence attribute." Social: "Boosts your Constitution attribute." Other: "Boosts your Perception attribute."

librarianmage commented 8 years ago

@Alys I think that makes sense, or it may make sense for the labels to just be what they raise ("Strength", etc.) On Mon, Feb 8, 2016 at 5:21 PM Alys notifications@github.com wrote:

I think @deilann https://github.com/deilann makes some good points about not overly specifying what they should be used for, and also about the need to state which attribute they affect.

Do we want to keep it as simple as this?

Physical: "Boosts your Strength attribute." Mental: "Boosts your Intelligence attribute." Social: "Boosts your Constitution attribute." Other: "Boosts your Perception attribute."

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-181618034.

Alys commented 8 years ago

@MathWhiz I think there's some benefit in not having the attributes displayed directly on the buttons. I think we want players to focus more on what kind of task it is, rather than on what attribute is affected (although providing the attributes as a hint on hover is still a good thing). If they want to focus on specifically what attributes are increased, then they're probably better of not using automatic task allocation.

Contrasting opinions are welcome! I'm not totally sold on what I've just written. :)

librarianmage commented 8 years ago

@Alys I think that makes sense. On Sat, Feb 13, 2016 at 9:37 PM Alys notifications@github.com wrote:

@MathWhiz https://github.com/MathWhiz I think there's some benefit in not having the attributes displayed directly on the buttons. I think we want players to focus more on what kind of task it is, rather than on what attribute is affected (although providing the attributes as a hint on hover is still a good thing). If they want to focus on specifically what attributes are increased, then they're probably better of not using automatic task allocation.

Contrasting opinions are welcome! I'm not totally sold on what I've just written. :)

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-183815379.

simbs commented 8 years ago

I don't use automatic task allocation, but Physical/Mental/Social/Other doesn't make much sense to me, even unrelated to the attributes. "Social" especially. If the only point of having these is to increase the corresponding attributes, why not just give them those names? Even for people who want to focus on which attributes are increasing, it makes sense that they might want to take the decision out of their own hands, and add more difficulty to the game. Ie if they want to increase attribute X, they have to complete tasks assigned with the corresponding thing, and they can add it to the most difficult ones. For what kind of task it is, the user can add it's own customized tags.

Of course if these are the categories most people would like to group things into, then what makes sense to me doesn't matter.

kdcarlsen commented 8 years ago

Is this something that still needs work? I'm looking to get involved. Also how can I tell if there is a pull request associated with this issue? I don't think there is but I'm not sure.

librarianmage commented 8 years ago

@kcswordfish My current understanding of this issue is that it is still under discussion, so if you have any suggestions, feel free to share them!

In most cases, if one submits a pull request associated with an issue, they will reference it using # notation, which will put a message in the comments of the issue.

kdcarlsen commented 8 years ago

Noted, thank you!

Any suggested tickets for somebody trying to get a feel for everything?

librarianmage commented 8 years ago

I would look through the "Help Welcome Now" issues, as they are generally ready for work to be done on them. On Sun, Mar 6, 2016 at 4:25 PM Kenny Carlsen notifications@github.com wrote:

Noted, thank you!

Any suggested tickets for somebody trying to get a feel for everything?

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-193008283.

kdcarlsen commented 8 years ago

Will do, thanks

lemoness commented 8 years ago

Reading through this discussion again, it sounds like the consensus is to change the names of the attributes to reflect the stats. Let's do that. I'm happy with deilann's proposed text:

Strength: e.g. relating to exercise and activity Intelligence: e.g. relating to academic or mentally challenging pursuits Perception: e.g. relating to work, or financial tasks Constitution: e.g. relating to health, wellness, and social interaction

librarianmage commented 8 years ago

I can do that! On Fri, Jun 3, 2016 at 8:43 PM lemoness notifications@github.com wrote:

Reading through this discussion again, it sounds like the consensus is to change the names of the attributes to reflect the stats. Let's do that. I'm happy with deilann's proposed text:

Strength: e.g. relating to exercise and activity Intelligence: e.g. relating to academic or mentally challenging pursuits Perception: e.g. relating to work, or financial tasks Constitution: e.g. relating to health, wellness, and social interaction

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2044#issuecomment-223729060, or mute the thread https://github.com/notifications/unsubscribe/ALz_8yuTCYqQJO8XyRgwPCp1u9RptQxjks5qINgzgaJpZM4BVAjX .