search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.84k stars 4.05k forks source link

Change Default tags to match types, not times of day #7933

Closed lemoness closed 8 years ago

lemoness commented 8 years ago

The default tags on the website, "morning", "afternoon", and "evening", have not been intuitive. Instead, we'd like to change them to match the categories created when setting up the mobile app:

Work Exercise Health + Wellness School Teams Chores Creativity

The default tasks should then each be pre-tagged with one of these corresponding tags, both on mobile and on the website, so that the user has a functioning tag system already set up.

librarianmage commented 8 years ago

I can do this!

librarianmage commented 8 years ago

Would you like emoji with them?

lemoness commented 8 years ago

My impulse would be to say yes, but I'm not sure if they'll show up correctly in the app. @vIiRuS, any insights?

librarianmage commented 8 years ago

@lemoness using the text won't work, but using the actual characters will On Mon, Aug 29, 2016 at 9:59 PM lemoness notifications@github.com wrote:

My impulse would be to say yes, but I'm not sure if they'll show up correctly in the app. @vIiRuS https://github.com/vIiRuS, any insights?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitrpg/issues/7933#issuecomment-243319525, or mute the thread https://github.com/notifications/unsubscribe-auth/ALz_88Z60PIA_9vBufxmyRnXaRp-POCyks5qk5ycgaJpZM4Jtnu8 .

lemoness commented 8 years ago

In that case, go ahead!

On Mon, Aug 29, 2016 at 8:01 PM, AccioBooks notifications@github.com wrote:

@lemoness using the text won't work, but using the actual characters will On Mon, Aug 29, 2016 at 9:59 PM lemoness notifications@github.com wrote:

My impulse would be to say yes, but I'm not sure if they'll show up correctly in the app. @vIiRuS https://github.com/vIiRuS, any insights?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/HabitRPG/habitrpg/issues/7933#issuecomment-243319525 , or mute the thread https://github.com/notifications/unsubscribe-auth/ALz_88Z60PIA_ 9vBufxmyRnXaRp-POCyks5qk5ycgaJpZM4Jtnu8 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitrpg/issues/7933#issuecomment-243319697, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVQwRLyJ5fdeNPGYUoD-foG4-uFP-5wks5qk5zwgaJpZM4Jtnu8 .

Alys commented 8 years ago

Actually I'm not sure the emoji characters will be a good idea because they display differently (sometimes very differently) in different platforms. The text emoji we use are standardised across all official Habitica platforms and I'd really like to encourage people to use them instead. The text emoji won't work yet on the mobile apps in the tag names, but I expect they will in future. I suggest that we use tags with no emoji for now and add the text emoji later when the apps support it.

Alys commented 8 years ago

Further to that: We've had people in the past complaining about changes in emoji appearance when we switched emoji libraries. I think they are also likely to complain if their tags look different on the mobile app compared to the website. Using text emoji (or no emoji) prevents that.

lemoness commented 8 years ago

Very good points. Let's hold off until tag names support text emoji, then.

On Mon, Aug 29, 2016 at 8:36 PM, Alys notifications@github.com wrote:

Further to that: We've had people in the past complaining about changes in emoji appearance when we switched emoji libraries. I think they are also likely to complain if their tags look different on the mobile app compared to the website. Using text emoji (or no emoji) prevents that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitrpg/issues/7933#issuecomment-243324022, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVQwS-8hKUr1FLNMpCpEB0oDVzxJnjSks5qk6VSgaJpZM4Jtnu8 .

DrStrangepork commented 8 years ago

Only commit a719e39 is valid

librarianmage commented 8 years ago

@DrStrangepork I was going to work on it 😔 (It's okay)

Alys commented 8 years ago

@DrStrangepork Before you start work on an issue, it's a good idea to first read through the comments to see if anyone else is working on it, and if there are recent comments indicating that they are, then it's best that you leave it to them. If you ever see an issue where the comments are old, it's okay to ask if the person is still working on the issue.

It's also best to comment on any issue before you start work, even on issues that aren't in progress. That helps to prevent anyone else starting work on it too and it gives the admins a chance to give you advice about the issue if necessary or to ask you to not proceed if something has come up that means the issue should not be resolved yet.

Please see "Ways to Help" > "Website" in Guidance for Blacksmiths for more information.

DrStrangepork commented 8 years ago

I apologize for jumping in. I was using this to validate my local install and just ran with it. I'll be nicer in the future. :frowning: