Closed OlegDev1 closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.89%. Comparing base (
826ba90
) to head (7069485
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you very much for the review, I really appreciate it!
I have added an additional button check in the test case as Frank suggested. I also replaced the non-null assertion with an error check
Description
Linked issue: #5193
Problem Even though the min date is provided, when selecting the second month, "previous month" button still appears. It shouldn't happen, because the calendar from the screenshots starts at November.
Changes Changed the calculation logic that determines whether previous month button should appear or not (borrowed some code from
renderMonths
, big thanks to @pmacmillan). Added a test case, in which a calendar is rendered with min date, after that the date from the second month is selected and it is expected for "previous month" button not to appear.Screenshots
Calendar starts at November 7
Before After
Contribution checklist