Hacktoberfest / hacktoberfest-2022

Hacktoberfest - Site for the annual open-source challenge, used for the 2022-2024 seasons.
https://hacktoberfest.com
Other
14 stars 15 forks source link

OpenCollective embed overflows beyond iframe #60

Open MattIPv4 opened 2 months ago

MattIPv4 commented 2 months ago

Information

Details

Description

On the donate page, projects from OpenCollective render an embed directly on the page, and the embed content appears to be taller than the embed expects, leading to the content being cut off (the FAQs).

Steps to reproduce

Access the donate page, expand a project from OpenCollective.

image

Expected behavior

Embed is sized correctly for the content within the iframe, ideally by talking to the iframe to get the height of the content within (see if OpenCollective has a documented way to do this using messaging, or potentially open an issue/PR in an appropriate repository on their side to implement such a thing).

Muhammad-Owais-Warsi commented 1 month ago

Hey @MattIPv4 , would love to solve the issue. Thanks :)

Muhammad-Owais-Warsi commented 1 month ago

Hey @MattIPv4 , would love to solve the issue. Thanks :)

Hey @erhilse @MattIPv4 @davidcarlsonberg, I was wondering if I should go ahead and raise the PR or wait to get officially assigned? I don't want to rush ahead, so just let me know whenever you have the time. Thanks!

davidcarlsonberg commented 1 month ago

Hey @MattIPv4 , would love to solve the issue. Thanks :)

Hey @erhilse @MattIPv4 @davidcarlsonberg, I was wondering if I should go ahead and raise the PR or wait to get officially assigned? I don't want to rush ahead, so just let me know whenever you have the time. Thanks!

Hi! Feel free to go ahead without being assigned, and thank you! Also, I've assigned you :).

Muhammad-Owais-Warsi commented 1 month ago

Hey @MattIPv4 , would love to solve the issue. Thanks :)

Hey @erhilse @MattIPv4 @davidcarlsonberg, I was wondering if I should go ahead and raise the PR or wait to get officially assigned? I don't want to rush ahead, so just let me know whenever you have the time. Thanks!

Hi! Feel free to go ahead without being assigned, and thank you! Also, I've assigned you :).

Sure, thanks