search

HalcyonGrid / halcyon

Halcyon 3d virtual reality world simulator
BSD 3-Clause "New" or "Revised" License
20 stars 20 forks source link

Pr102 fix #125

Closed emperorstarfinder closed 3 years ago

emperorstarfinder commented 3 years ago

This PR fixes a crash caused by the missing water texture from PR https://github.com/HalcyonGrid/halcyon/pull/102

Vinhold commented 3 years ago

Running the release Halcyon.0.9.44 threw this exception: Halcyon 0.9.44 Error: APPLICATION EXCEPTION DETECTED: System.UnhandledExceptionEventArgs

Exception: System.IO.FileNotFoundException: Could not find file 'C:\3DWorldz\Wor ld\9500\assets\TexturesAssetSet\43c32285-d658-1793-c123-bf86315de055.jp2'. File name: 'C:\3DWorldz\World\9500\assets\TexturesAssetSet\43c32285-d658-1793-c1 23-bf86315de055.jp2'

Actual filename: 43c32285-d658-1793-c123-bf86315de055.j2c

I changed the name of the file to 43c32285-d658-1793-c123-bf86315de055.jp2 and Halcyon loaded correctly so this is its only error in starting up.

kf6kjg commented 3 years ago

New workarounds:

emperorstarfinder commented 3 years ago

no workarounds needed folks, a fix is already incoming.

Vinhold commented 3 years ago

Why is that entry not a named texture entry also? I put the UUID on a cube to see what it was and its a dark blue marble sort of appearance.

emperorstarfinder commented 3 years ago

It is supposed to be the water texture that viewers need when the water is set to an invisible in-world. Can you send me a picture of what you are seeing via discord?

Vinhold commented 3 years ago

Done! :)

Vinhold commented 3 years ago

Some oddities. Not finding where to post this stuff! Halcyon Prerelease 0.9.45: The regions load way faster than expected, not appearing to load the Library XML or that process has been improved a 100% for speed operation! The file AssetSets.xml.loaded is being created on region startup. But the long wait while loading does not appear to happen.

I do not know what the name of the default water that was added is. No water named item appears in the Library textures list.

I did notice that the Library scripts list contains a folder for OpenSim Specific Scripts containing osSetDynamicTextureData() or osSetDynamicTextureURL(). Of course none of the three listed scripts will work in Halcyon as is. Not sure those functions even exist in Halcyon. So I recommend that folder entry and referenced script assets be removed before official release.

kf6kjg commented 3 years ago

You'd start by posting commentary in a relevant channel of the the Discord server. Issue comments should be limited to only info relevant directly to the issue.

emperorstarfinder commented 3 years ago

As I already explained to Vinhold via discord, the water texture does not need to be listed in the TexturesLibrary.xml file. It is only intended to be used by the viewer in the event the user disables transparent water settings via the viewer preferences.

I did not optimize anything else as far as the loading of the libraries so the fact is loading faster is a good thing.

The OpenSim Specific scripts probably can be safely removed as my understanding is that OSSL support was removed when InWorldz replaced the scripting engine with Phlox. So the three OSSL scripts are not needed.