Open dacb opened 5 years ago
This is a good question. I'm not sure what the convention is. Things work as it's set up now, so unless it's super weird to have the data not in the package I think the plan is to leave this as it is.
Actually...we might want some feedback on this. I see some advantages to moving it. We'll bring it up in the presentation.
Great!
-- David A. C. Beck, Ph.D. dacb@uw.edu http://faculty.washington.edu/dacb/ Research Associate Professor, Dept. of Chemical Engineering Director of Research & Senior Data Science Fellow - eScience Institute Adjunct Associate Professor of Paul G. Allen School of Computer Science & Engineering Adjunct Research Associate Professor, Env. and Occ. Health Sciences Associate Director - NRT Data Intensive Research Enabling Clean Technologies University of Washington, Seattle
On Dec 11, 2018, at 3:59 PM, rpclancy notifications@github.com wrote:
Actually...we might want some feedback on this. I see some advantages to moving it. We'll bring it up in the presentation.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HamidPahlavan/climops/issues/4#issuecomment-446409272, or mute the thread https://github.com/notifications/unsubscribe-auth/AGL1-lko_OSrsG7Lgy5MWk-6nPWuxwW8ks5u4EbHgaJpZM4ZHbul.
One thing to consider... are there licenses on the data that are separate from your code? In which case you probably should acknowledge them. If you are using the data in the unit tests, then it needs to be in the package directory.
Thanks :) I'll try moving it over, cross my fingers and hope it doesn't break everything.
It’s under version control right? So if it all catches fire and burns, just revert to the previous version.
-- David A. C. Beck, Ph.D. dacb@uw.edu http://faculty.washington.edu/dacb/ Research Associate Professor, Dept. of Chemical Engineering Director of Research & Senior Data Science Fellow - eScience Institute Adjunct Associate Professor of Paul G. Allen School of Computer Science & Engineering Adjunct Research Associate Professor, Env. and Occ. Health Sciences Associate Director - NRT Data Intensive Research Enabling Clean Technologies University of Washington, Seattle
On Dec 11, 2018, at 6:27 PM, rpclancy notifications@github.com wrote:
Thanks :) I'll try moving it over, cross my fingers and hope it doesn't break everything.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HamidPahlavan/climops/issues/4#issuecomment-446438291, or mute the thread https://github.com/notifications/unsubscribe-auth/AGL1-kJ09k_qZhvDg22Uy91yFfk1F5aZks5u4GmfgaJpZM4ZHbul.
I don't know the answer to this question, but maybe you want to put the data directory in the package and not the repo.