search

Harmonic / inertia-table

Easy creation and management of Inertia tables using Eloquent models
Other
55 stars 24 forks source link

Not compatible with Laravel 8.0 with jetstream #18

Open viamedev opened 4 years ago

viamedev commented 4 years ago

Please make it compatible with the latest and greatest. I'm sure all the requirements are met by default, just need a few tweaks to make it officially compatible.

Great package btw!

nachiomdq commented 3 years ago

+1 Laravel 8 jetstream

JoshZA commented 3 years ago

👍

gbrits commented 3 years ago

+1

Using version ^1.0 for harmonic/inertia-table
./composer.json has been updated
Running composer update harmonic/inertia-table
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - harmonic/inertia-table[v1.0.0, ..., v1.0.5] require illuminate/support ~5 -> found illuminate/support[v5.0.0, ..., 5.8.x-dev] but it conflicts with another require.
    - harmonic/inertia-table[v1.0.6, ..., v1.0.7] require illuminate/support ~5 || ~6 -> found illuminate/support[v5.0.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev] but it conflicts with another require.
    - Root composer.json requires harmonic/inertia-table ^1.0 -> satisfiable by harmonic/inertia-table[v1.0.0, ..., v1.0.7].

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

I was really eager to use this, the VueJS side of things installed and set up without a hitch. Is it not just a tweak of the composer.json version values to fix this issue?

gbrits commented 3 years ago

I'm trying to push an update (Merge request) to the repo, ran into this snag

./composer.json has been updated
Running composer update harmonic/inertia-table
Loading composer repositories with package information
Updating dependencies
Lock file operations: 2 installs, 0 updates, 0 removals
  - Locking harmonic/inertia-table (dev-master)
  - Locking reinink/remember-query-strings (v0.1.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Installing reinink/remember-query-strings (v0.1.0): Extracting archive
  - Installing harmonic/inertia-table (dev-master): Symlinking from inertia-table
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

PHP Fatal error:  Trait 'Illuminate\Console\DetectsApplicationNamespace' not found in /Users/xxxxxx/inertia-table/src/Commands/MakeInertiaTable.php on line 12

Looks like this was deprecated quite some time ago, around Laravel 7 - sourcing the alternative now

wannymiarelli commented 3 years ago

@gbrits

Seems like this could be easily replaced by the new

Illuminate\Console\DetectsApplicationNamespace;

Had no time to try it, but will do asap.

craigharman commented 3 years ago

Thanks @wannymiarelli

If you are happy to implement this send through a PR and I'll get it live.

gbrits commented 3 years ago

I ended up hardcoding App\Models into mine and got it all working with Laravel 8. I can create a PR for this if you want?

craigharman commented 3 years ago

Sounds great @gbrits send it through and I'll take a look! Thanks!

ttquoccuong commented 3 years ago

I got same issue. Any sugguest to fix inwhile waiting for merge complete? Thanks so much!

@craigharman @gbrits

futurewebsites commented 3 years ago

any luck with this?