[Help Needed] All offer acceptance emails going to seller only

[that1guy]

Since buyers and sellers can "ping pong" offers back in forth as counter proposals we need to send offer acceptance email to the correct party. Today all offer acceptance emails are going to seller only.

[brozeph]

For reference:

• See https://github.com/HashtagSell/notification-svc/blob/develop/lib/models/notifications/new-offer-proposal.js#L33
• See https://github.com/HashtagSell/notification-svc/blob/develop/lib/models/queues.js#L33

Both of the above areas in the code required change to address this - now keying off of the offer.proposal.isOwnerReply value.

What I missed here is that the posting-api always emits offer-update events with the buyer as the username value, which is technically incorrect. Changing this would have deeper repercussions, however... and for the purposes of the notification-svc, the newly introduced changes are a positive decoupling.

[brozeph]

Assigning to @that1guy for verification

[that1guy]

Offer acceptance emails are only going to one party still. I'll be taking a look at this tomorrow eve.