search

HausDAO / monorepo

MIT License
24 stars 16 forks source link

Transaction Builder Form: ABI Paste/Fetch error #303

Open skuhlmann opened 1 year ago

skuhlmann commented 1 year ago

Feature

Multicall Transaction Builder Proposal Form

App

Expected Behavior

  1. Put contract address into contract field
  2. App fetches the abi and puts contents into the abi field
  3. Then try to paste in an implementation ABI - it should override the fetched abi

Actual Behavior

I noticed an issue in the multi-tx builder. When I select a contract it pulls the ABI, but I need to drop in the implementation ABI. I found it and pasted it in, but the ABI fetch happens again and replaces it. I had to brute force (ctrl-v multiple times) to get it to give me what I wanted.

https://discord.com/channels/709210493549674598/908738422666063892/1104485279127052451

Steps to Reproduce

No response

Browser

No response

Screenshots and Context

No response

santteegt commented 1 year ago

Info to replicate the issue:

The contract I was trying to call was: 0x594E630efbe8dbd810c168e3878817a4094bB312
The ABI I was trying to paste in was from 0x882881c5A49A71C31B6956b06AF8C7a33AF1cdD6
scottrepreneur commented 7 months ago

Also seeing this when trying to use a proxy contract. Need to paste implementation ABI for correct functions. Superfluid tokens are proxy implementations.