search

Headline / Gangs

Gangs for Jailbreak Servers Running SourceMod
GNU General Public License v3.0
17 stars 7 forks source link

Inviting two people at the same time breaks the max player limit #37

Closed Nachtfrische closed 6 years ago

Nachtfrische commented 6 years ago

A user reported this interesting bug to me:

According to him, he had 14 out of 15 max people in his gang and invited two people. Both accepted and he now has 16/15 people. In theory, this could be abused even further by having one open spot and then inviting as many players as you could so you would get over the player limit.

Before accepting the invite, a check should be made to verify that the gang is not full and still has an open spot for a player join.

Headline commented 6 years ago

It looks like these checks are in place, do you happen to have size disabled? It still shows the size regardless of the fact that it's "limitless"

I've made a change regarding that clarification #38, if that is what the issue is

Nachtfrische commented 6 years ago

The size is enabled, maybe it was just a database quirk, I don't know since I didn't try to reproduce the issue. So far, I didn't hear anyone else complain about this issue, so I'm going to close this.

Thanks!