search

HearthSim / Arcane-Tracker

An automatic Hearthstone tracker for Android
https://arcanetracker.com/
Other
148 stars 36 forks source link

Enable Collection Tracking #106

Open Salsicha21300 opened 6 years ago

Salsicha21300 commented 6 years ago

HS deck tracker on PC works with HS replay to detect and upload your collection. This would be very useful in an android application.

martinbonnin commented 6 years ago

Sorry that's not going to happen on Android. The PC trackers hook into the program memory to read the card collection. That is not possible on non-rooted Android devices due to security reasons. We technically could do it for rooted devices but this is a lot of effort for a very small user base.

eddie-97 commented 6 years ago

Is it possible to track cards you open from packs? Maybe there can be a work around. If it is then maybe have it where manually you select the cards you have currently, and the app will track what you got.

And if that's not possible due to what you said, security issues, then how about where manually you would add the cards you have but have a separate tab where you can add the 5 cards you just got and it would update your collection.

Think of it like a piggy bank. You have whatever money in there and anything you get is like adding loose change.

Thoughts?

On Mon, Aug 20, 2018, 4:34 AM Martin Bonnin notifications@github.com wrote:

Sorry that's not going to happen on Android. The PC trackers hook into the program memory to read the card collection. That is not possible on non-rooted Android devices due to security reasons. We technically could do it for rooted devices but this is a lot of effort for a very small user base.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HearthSim/Arcane-Tracker/issues/106#issuecomment-414256466, or mute the thread https://github.com/notifications/unsubscribe-auth/AXOo40kvWJjjlv9Kqeef8cLOs3HNjzbYks5uSoKNgaJpZM4WDpRO .

martinbonnin commented 6 years ago

Sounds like a good idea. We'll look into that. Reopening the issue.

l3laze commented 4 years ago

@martinbonnin Has this been looked into more at all yet? Is there any possibility the logs have changed and it may be possible to do so now?

As an alternative possibility, what about a persistent local DB of cards a user has historically used in decks? The counter can max at 2/ea, it should be simple to output in the same format for uploading as on the PC, and it could use the file's last-changed timestamp to tell when it needs to update the server.

From what [little] I can understand of the code it seems like it would be possible. It may also need an option to toggle it on/off in the UI as it could cause initial lag after creating a new deck.

martinbonnin commented 4 years ago

Remembering the "seen cards" would work. It would still require some merge logic so as not to overwrite the collection uploaded on Mac/PC if a user plays on multiple platforms. Also obviously it will miss a lot of cards.

l3laze commented 4 years ago

Ah, I figured there would be functionality to handle collection updates on the server-side already; that complicates things a bit.

Yeah, that's true; so at that point I guess it would just help simplify/kickstart the online collection management for mobile players as, at least on Android, there doesn't seem to be any good tools for those of us who don't know every card name or aren't willing to use unintuitive apps.

I guess it probably would be simpler in most ways to just build a better collection manager/deckbuilder/etc other things AT doesn't/shouldn't do instead of adding more to it.

Sorry I didn't think it through further, lol.

martinbonnin commented 4 years ago

No pb, thanks for the feedback. Another approach would be to do image processing and have the user scroll though the library. But all these approaches have significant downsides and are non-trivial to implement.