search

HearthSim / Arcane-Tracker

An automatic Hearthstone tracker for Android
https://arcanetracker.com/
Other
148 stars 36 forks source link

Add Darkmoon to Standard Sets #159

Closed jk2112 closed 3 years ago

jk2112 commented 3 years ago

This should fix the secret tracker to display Darkmoon secrets.

martinbonnin commented 3 years ago

Hi ! Thanks for looking into this! While this will show the secrets, it will not detect them, you'll need to add the matching logic to SecretLogic.kt

jk2112 commented 3 years ago

I knew that was too easy! Here's a draft of the logic. The opponentWasDamaged variable is pretty rough, I'm open to feedback if there's a better way to do that using the entity, key, and tag objects.

jk2112 commented 3 years ago

I'm a bit lost on this build error. Updating Gradle and editing build.gradle fixed the build on my local machine. Do you have to update Gradle on your build machine or is this something on my end?

martinbonnin commented 3 years ago

Updating Gradle and editing build.gradle fixed the build on my local machine. Do you have to update Gradle on your build machine or is this something on my end?

That error happened because the GOOGLE_PLAY_JSON is a secret on github that's not available to pull request. This is to avoid someone opening a pull request and reading the secrets. I changed the CI scripts to use the mock in that case, hopefully that'll work better now 🤞

The opponentWasDamaged variable is pretty rough, I'm open to feedback if there's a better way to do that using the entity, key, and tag objects.

opponentWasDamaged looks legit to me. This has to be stateful in all cases 👍

jk2112 commented 3 years ago

The Freezing Trap fix is for Issue #144, if that's too unrelated I can take it out and put it in its own PR.

martinbonnin commented 3 years ago

The Freezing Trap fix is for Issue #144, if that's too unrelated I can take it out and put it in its own PR.

No problem at all, thanks for fixing this!

Undefined symbols for architecture x86_64:
  "_objc_setHook_setAssociatedObject", referenced from:
      _platform_objc_objc_setHook_setAssociatedObject_wrapper100 in libobjc-cache.a(result.o)
     (maybe you meant: knifunptr_platform_objc100_objc_setHook_setAssociatedObject

That's a new one... Never seen this before. Looks related to https://youtrack.jetbrains.com/issue/KT-43128

martinbonnin commented 3 years ago

There's one last error on CI about signing release build which is another issue with github secrets. I'll fix this in master. Thanks for the contribution !