search

HearthSim / Arcane-Tracker

An automatic Hearthstone tracker for Android
https://arcanetracker.com/
Other
148 stars 36 forks source link

fix local builds where signing configurations are not available. #26

Closed williamwebb closed 8 years ago

martinbonnin commented 8 years ago

How do I override the "arcane_tracker.signing" property in my local build ?

williamwebb commented 8 years ago

You want to create a ~/.gradle/gradle.propreties file and place the value there.

martinbonnin commented 8 years ago

Can't make it work :-(. I tried echo "arcane_tracker.signing=true" > ~/.gradle/properties and then when trying to build in release, I get something like this: "The apk for your currently selected variant is not signed."

williamwebb commented 8 years ago

I will try locally. Do you know if arcane_tracker.signing is being resolved?

martinbonnin commented 8 years ago

Complete newbie in terms of gradle, sorry, how would I test that ? Or else something like this ? https://www.thoughtworks.com/insights/blog/signing-open-source-android-apps-without-disclosing-passwords

williamwebb commented 8 years ago

I tested this (added an exception inside the if block) and it should be working. I think you may have not have gotten the variable setup right.

martinbonnin commented 8 years ago

the full statement needed to be signingConfig signingConfigs.mbonnin and not just signingConfigs.mbonnin. I'm merging this and will fix it in master. (edit: see https://github.com/HearthSim/arcane_tracker/commit/790e02a6c246d510e06a1f084adaec056fff622a)

Also, I'll move to https://www.thoughtworks.com/insights/blog/signing-open-source-android-apps-without-disclosing-passwords at some point.

williamwebb commented 8 years ago

Awesome. & i agree.