search

HearthSim / Joust

🍿 Hearthstone replays in your browser.
https://hearthsim.info/joust/
118 stars 20 forks source link

Handle non-square textures #122

Closed jleclanche closed 8 years ago

jleclanche commented 8 years ago

Joust shouldn't assume square textures.

image

https://hsreplay.net/replay/avHw7bMDcbARKjfQxA47cm#turn=31a

beheh commented 8 years ago

There's really no simple fix for this, it's extremely tricky to maintain aspect ratio and crop images if we can't rely on them being square, portrait or landscape. Will probably not happen until we have a Javascript-based card renderer.

jleclanche commented 8 years ago

Alright, well I'm now generating 512x and 256x thumbnails which guarantee squareness.

Also, blizzard squareified the texture :)

beheh commented 8 years ago

:+1:

Closing for now, since it's not really feasible with the current renderer.