Attribute error in Zone class raised from fireplace test

HearthSim / python-hearthstone

Hearthstone Python library (CardDefs, DBF, enums, log parser)

MIT License

246 stars 62 forks source link

Attribute error in Zone class raised from fireplace test #22

Closed d3sm0 closed 7 years ago

d3sm0 commented 7 years ago

tests_hero_powers from fireplace library seems raising an attribute error due to the missing attribute in Zone.DISCARD, which appear to be missing in this line. Can this simply be fixed with? DISCARD = 8

https://github.com/HearthSim/python-hearthstone/blob/35e104920747da00fdb72e22802c0e8aee30407b/hearthstone/enums.py#L766

jleclanche commented 7 years ago

This is something that needs to be fixed in fireplace. There is no discard zone in HS, that was something I had implemented at the time for simplicity (splitting the graveyard and discards). Hop on the discord server if you wanna chat about that.