search

HearthSim / python-hearthstone

Hearthstone Python library (CardDefs, DBF, enums, log parser)
MIT License
246 stars 62 forks source link

Add missing PlayReq enum #43

Closed shinoi2 closed 8 months ago

shinoi2 commented 8 months ago

Add missing PlayReq enum

Add Lackey Cards

Ref: https://hearthstone.fandom.com/wiki/Lackey

Add COPIED_CARDS_WILD_EVENTS_MAP

Ref: https://hearthstone.fandom.com/wiki/Wild_Event

beheh commented 8 months ago

Hey there, thanks for your contributions! A few things:

  1. All contributions to HearthSim require a signed CLA. I've sent you an invite to the repository, please follow the instructions there. If you've already signed the CLA, please let us know. Once that's done and the CLA has been merged, we'll try to get this merged here as soon as possible.
  2. Your PR is adding very different things. Could you please pull them into different PRs, so we can decide and merge them individually?
  3. The Wild Event cards don't exist in the game client today, at least with the ids you've submitted. So I don't believe that changeset makes sense. Can you give some more context on why you'd need it?
shinoi2 commented 8 months ago
  1. I have signed.
  2. I will split it later.
  3. I'm developing Fireplace uldum version (Patch 15.6.2.36393) that include Wild Event. Code. Even if wild events are removed, there will have no effect. Another way is to store the Wild Event to the fireplace and remove it when fireplace updates.
shinoi2 commented 8 months ago

Splited, check out new PRs. https://github.com/HearthSim/python-hearthstone/pull/45 https://github.com/HearthSim/python-hearthstone/pull/46 https://github.com/HearthSim/python-hearthstone/pull/47

beheh commented 8 months ago

@shinoi2 Hey, just to get the CLA process wrapped up, can you make sure to open a PR in the repository as outlined in the instructions there? I don't see anything from you. If I missed it, could you please link it?