Closed shinoi2 closed 4 months ago
I can't verify these. How did you source them and the names?
If you came up with the names yourself, there's a section at the bottom of the enum for guessed tag values.
I find them in https://github.com/HearthSim/hsdata/blob/master/CardDefs.xml.
GameTag.UPGRADED_HERO_POWER
Basic warrior hero power [HERO_01bp] Armor Up!
include <Tag enumID="1086" name="2745" type="Int" value="2745"/>
,
and the upgraded hero power [HERO_01bp2] Tank Up!
id is 2745.
Obviously 1086
represents the upgraded hero power, and the same applies to other basic hero powers.
GameTag.LIBRAM
[BT_020] Aldor Attendant
and [BT_026] Aldor Truthseeker
Reduce the Cost of your Librams.
All Libram cards have <Tag enumID="1546" name="1" type="Int" value="1"/>
GameTag.SI_7
SI:7 is a term used to refer to various cards that specifically relate with the rogue Questline, Find the Imposter, as well as other SI:7-related rogue cards.
All SI:7 cards have <Tag enumID="1678" name="1" type="Int" value="1"/>
Anything update?
Sorry for the delay, I forgot about this.
In that case, let's put these in the "Guessed" section at the bottom of the class because we're not 100% sure that the games calls them this. Then we can merge it.
@beheh
Thanks for your contribution! I've releases this as python-hearthstone v9.7.0.
@beheh Please review this PR.