HearthSim / python-hearthstone

Hearthstone Python library (CardDefs, DBF, enums, log parser)
MIT License
246 stars 62 forks source link

Add GameTag.UPGRADED_HERO_POWER, GameTag.LIBRAM and GameTag.SI_7 #50

Closed shinoi2 closed 4 months ago

shinoi2 commented 7 months ago

@beheh Please review this PR.

beheh commented 7 months ago

I can't verify these. How did you source them and the names?

If you came up with the names yourself, there's a section at the bottom of the enum for guessed tag values.

shinoi2 commented 7 months ago

I find them in https://github.com/HearthSim/hsdata/blob/master/CardDefs.xml.

shinoi2 commented 5 months ago

Anything update?

beheh commented 5 months ago

Sorry for the delay, I forgot about this.

In that case, let's put these in the "Guessed" section at the bottom of the class because we're not 100% sure that the games calls them this. Then we can merge it.

shinoi2 commented 4 months ago

@beheh

beheh commented 4 months ago

Thanks for your contribution! I've releases this as python-hearthstone v9.7.0.