HeavensGate / Eternal

Heaven's Gate Station's homebrew based on Baystation12 ( https://github.com/Baystation12/Baystation12 ) //
http://forums.hgstation.xyz/
Other
3 stars 15 forks source link

Destroyed APCs can't be removed #237

Open Mewchild opened 9 years ago

Mewchild commented 9 years ago

If an APC is destroyed, be it by explosion, blob, or some such other, it can't be removed, and must be admin deleted/ignored.

Davnik commented 9 years ago

I believe the specific issue was with a "melted" APC, by a bluespace artillery strike. Let me know if more types of destroyed APC aren't removable.

Mewchild commented 9 years ago

https://i.gyazo.com/52f847641c8d896b73888695d13d61dc.png APC was destroyed by explosion, putting it into the "broken" icon state: https://i.gyazo.com/67fffcd11e32d9ebc9a020c7f1e9cee6.png. Was able to use screwdriver to expose electronics, then no other tool was able to interact with it from there. Also tested on the tile in front of it, no dice.

Mewchild commented 9 years ago

I've noted that in the live server, when an APC is broken by an event, we normally get an ahelp shortly thereafter, to delete the remains (as they can't be interacted with).

Davnik commented 9 years ago

All of these sections of code could be the source of a problem with APC deconstruction. C:\Eternal\code\game\objects\items\apc_frame.dm C:\Eternal\code\modules\power\apc.dm C:\Eternal\code\modules\power\terminal.dm C:\Eternal\code\game\turfs\simulated\walls.dm 433-436 C:\Eternal\code\modules\power\cable.dm 319-321

Mewchild commented 8 years ago

I'll test this further, I haven't seen the issue in a while

Davnik commented 8 years ago

If this is still a thing, it's a very usual, very public nuisance, which elevates its priority.