Some Quality of Life Changes

Hedroed / png-parser

Analyse PNG file format for CTF, python API and CLI

MIT License

93 stars 10 forks source link

Some Quality of Life Changes #4

Closed VoidTwo closed 2 years ago

VoidTwo commented 2 years ago

Added Pillow as a dependency since a few scripts imported it
Added more type hints throughout (not 100% type hinted)
Made strings consistent across the Python files since there was a mix between "" and '' strings
Some minor reformatting
Optimized the public screen images

Note: I believe there may be some breaking changes for older scripts written for png-parser since I renamed a few functions to be lowercase instead of camelcase.

VoidTwo commented 2 years ago

Thank you very much for all this work.

I just notice that you replace the logger string with fstring, I prefer to follow the logging-fstring-interpolation rule of pylint (in old mode) as this optimizes the logger.

Can you go back and change the logger messages?

Thank you for this information, I wasn't aware of how the logging library handled strings. I have pushed the change you have requested.