Heegu-sama / Homm3BG

Repository for rewriting the rule book.
119 stars 24 forks source link

Refactor version handling during build and release #555

Closed tomaas-zeman closed 3 months ago

tomaas-zeman commented 3 months ago

Based on the previous discussion https://github.com/Heegu-sama/Homm3BG/pull/553#discussion_r1626067929

qwrtln commented 3 months ago

This will not work without refactoring the workflow.

qwrtln commented 3 months ago

Based on the previous discussion #553 (comment)

* versions are also replaced in `README` links during release

I'm not sure if it's necessary. Readme evolves every time there's a release. We're not at the point where we need automation here. If anything, it should be a separate script, because I don't want to edit README when I build the release files. And you run it once for every language. And no, I don't want it to build every language on a single run, as a simple bash for loop will do. I want the capability to build a single language.

tomaas-zeman commented 3 months ago

Based on the previous discussion #553 (comment)

* versions are also replaced in `README` links during release

I'm not sure if it's necessary. Readme evolves every time there's a release. We're not at the point where we need automation here. If anything, it should be a separate script, because I don't want to edit README when I build the release files. And you run it once for every language. And no, I don't want it to build every language on a single run, as a simple bash for loop will do. I want the capability to build a single language.

OK. I'll revert that change

qwrtln commented 3 months ago

Ok, the project builds now in TeXstudio, nicely done. Need somebody to test it on Windows 😂

qwrtln commented 3 months ago

@csagataj2 You were the one? Please share some good news with us and tell us if it builds.

tomaas-zeman commented 3 months ago

@qwrtln It seems that job config change also changed the structure of checks and the deprecated ones are not running now, yet they still seem to be required

Screenshot 2024-06-05 at 15 36 09
qwrtln commented 3 months ago

@qwrtln It seems that job config change also changed the structure of checks and the deprecated ones are not running now, yet they still seem to be required

Screenshot 2024-06-05 at 15 36 09

Required checks are picked manually in the repo settings, to which only the owner has access. Since the jobs evolved (matrix has different params now), old ones need to be deleted and the new ones selected. We shall do it once we have confirmation that everything's working as intended.

csagataj2 commented 3 months ago

@csagataj2 You were the one? Please share some good news with us and tell us if it builds.

It works as intended

qwrtln commented 3 months ago

@csagataj2 You were the one? Please share some good news with us and tell us if it builds.

It works as intended

I'm glad we're leaving this window of opportunity open for everyone

qwrtln commented 3 months ago

@Heegu-sama We need your help here. Those yellow required checks which won't run now need to go away. They should be replaced by those which run successfully, but are not labelled as required.