Set 🇨🇿 table/note font to liberation + remove \vspace hacks for 🇨🇿 🇪🇸

Heegu-sama / Homm3BG

Repository for rewriting the rule book.

119 stars 24 forks source link

Set 🇨🇿 table/note font to liberation + remove \vspace hacks for 🇨🇿 🇪🇸 #590

Closed tomaas-zeman closed 3 months ago

tomaas-zeman commented 3 months ago

Few things in this PR

Using liberation font for Czech notes and tables to fix styling problems https://github.com/Heegu-sama/Homm3BG/issues/556#issuecomment-2161112358
Czech and Spanish have different styles for subsections (https://github.com/Heegu-sama/Homm3BG/issues/556#issuecomment-2161221451) which resulted in many hacks in .po files. This removes all the hacks and sets a global setting for these two languages.
To fix layouts after these changes, I had to make small text tweaks that need review from translators

pages

tomaas-zeman commented 3 months ago

The build fails due to "too many passes" - the issue is that the text on trading page is too long for Spanish. Workaround might be to specify gold dragon to be only 0.95\textwidth for Spanish but ideally we want to fix the translation

qwrtln commented 3 months ago

I think the existing font (on the left) looks better than what you're proposing (on the right):

Can't we have the left option everywhere, instead of forcing languages working correctly into the right option?

qwrtln commented 3 months ago

Or, at least make separate PRs for the following:

Czech fixes and typos
Spacing adjustments
Font fixes for tables and note boxes

tomaas-zeman commented 3 months ago

I think the existing font (on the left) looks better than what you're proposing (on the right):

Can't we have the left option everywhere, instead of forcing languages working correctly into the right option?

The left option is ptm and doesn't work everywhere. The right one is the default font. Maybe we can just tweak the style a bit for notes so it looks more like ptm but I think we shouldn't keep ptm as it's causing issues for cs, ua, ru languages.

Maybe we should even drop ptm from section headers and use the liberation font, we know that works

tomaas-zeman commented 3 months ago

Or, at least make separate PRs for the following:

Czech fixes and typos

Spacing adjustments

Font fixes for tables and note boxes

I thought about it but it's all connected - spacing and font changes both break the layouts and I don't want to fix it twice. There are actually no Czech typo fixes, it's part of shortening the text to fit the layout (as I did for pl and es)

EDIT: Maybe at this point, I can just move the font discussion out and it shouldn't break anything - if anything the note text gets shorter

tomaas-zeman commented 3 months ago

@qwrtln I changed the PR - it now only contains subsection changes for es and cs + liberation font for cs note boxes and tables.

tomaas-zeman commented 3 months ago

@Heegu-sama Could I ask for review here?

tomaas-zeman commented 3 months ago

@luischos Could you review changes in Spanish?