search

Heholord / FalconStats

MIT License
446 stars 20 forks source link

Scripts converted to bash #10

Open darookee opened 6 years ago

darookee commented 6 years ago

I'm not sure if I should create a pull request, so I thought I just create an issue and let you guys decide if you are interested. I converted the ssl, discspace and hddtemp script from nodejs to bash, which lightens this whole thing as nodejs would not be required to run this and still get a beautifull MOTD output. The hddtemp script currently does not display the temperatures in columns, but this could probably implemented. You can find the scripts here.

What is missing is a simple configuration wizzard, but I added all the configuration options to ./scripts/config.sh which is included by the scripts when they run.

ghost commented 6 years ago

I'm a fan. All of these work for me as well.

dj95 commented 6 years ago

A friend and me converted a few of the scripts into bash, too. They're mostly work in progress, but may be interesting for you.

https://github.com/nullbleed/fancy-motd

Heholord commented 6 years ago

Hey @darookee and @dj95 (@nullbleed), you are always welcome to send pullrequests. It's the goal to convert the nodejs scripts into bash even, because it promises to be more performant and less dependency rich. My suggestion would be to keep both versions of the scripts in separate folders.

HermannBjorgvin commented 6 years ago

Sounds good, I'd love to get more bash scripts rather than nodejs. It saves hundreds of milliseconds in runtime and is more performant like you said.

Please open a PR so we can review them for a while before merging :)

darookee commented 6 years ago

I got my branch out of scope, so I recreated it (in case anyone is wondering why the history is different now...) and created a pull request. When/If that is merged I'd open another PR for services.sh also using the config.sh used by these three scripts. The other shell scripts don't have anything to configure at the moment...

Heholord commented 6 years ago

@darookee I merged your pull request, i guess now we need to update the readme and write an interactive config script for the config.sh as well as an startup script. Maybe I'll look into this soon but as for now i don't find much time

ric2b commented 6 years ago

@dj95 I love your version, minimal dependencies, super simple to customize and fast!