Hekili / hekili

Hekili Priority Helper for DPS and Tanks (WoW Retail)
426 stars 220 forks source link

Warlock: Affliction: Impending Catastrophe and CDs without Phantom Singularity issue #1103

Closed tflo closed 3 years ago

tflo commented 3 years ago

Since recently I often see this error in BugSack:

1004x [string "-- Affliction:aoe:12..."]:2: attempt to call a boolean value
[string "-- Affliction:aoe:12
return safebool( (covenant.venthyr and (cooldown.impending_catastrophe.ready or dot.impending_catastrophe_dot.ticking) and cooldown.summon_darkglare.ready and (dot.phantom_singularity.remains>2 or not (talent.phantom_singularity.enabled))) and ((covenant.necrolord or covenant.kyrian or covenant.none) and cooldown.summon_darkglare.remains<2 and (dot.phantom_singularity.remains>2 or not (talent.phantom_singularity.enabled)))(covenant.night_fae and (cooldown.soul_rot.ready or dot.soul_rot.ticking) and cooldown.summon_darkglare.remains<2 and (dot.phantom_singularity.remains>2 or not (talent.phantom_singularity.enabled))) )"]:2: in main chunk
[string "=(tail call)"]: ?
[string "@Hekili\Core.lua"]:799: in function `GetPredictionFromAPL'
[string "@Hekili\Core.lua"]:840: in function `GetPredictionFromAPL'
[string "@Hekili\Core.lua"]:1369: in function `GetNextPrediction'
[string "@Hekili\Core.lua"]:1745: in function `ProcessHooks'
[string "@Hekili\UI.lua"]:824: in function <Hekili\UI.lua:689>

“Often” here means ‘not regularly but not rarely’.

I think, I started seeing this error when I began to play around with Vile Taint and Sow the Seeds instead of Phantom Singularity.


Things I’m observing that might be related to that error:

Concerning the second point, it almost seems as if the script was waiting for Phantom Singularity to be casted (which will never happen, since the talent is not selected). It’s weird though that the CD recommendation appeared once today.

With Phantom Singularity selected, nothing of the above does happen. That is, the CDs are recommended regularly, also for small mobs or dummies, and also Impending Catastrophe is recommended.

I just spent 10 minutes hammering on target dummies, in order to further narrow down the occurrence of the error, but… it didn’t appear now.


Click here for the Hekili “Character Data” info. ``` build: v9.0.5-1.0.8 level: 60 (60) class: WARLOCK spec: affliction talents: dark_caller dark_soul_misery demon_skin drain_soul howl_of_terror siphon_life vile_taint pvptalents: none covenant: venthyr conduits: accrued_vitality = 5 focused_malignancy = 5 rolling_agony = 5 shade_of_terror = 5 soulbinds: [nadjia_the_mistblade] agent_of_chaos = 1 familiar_predicaments = 1 friends_in_low_places = 1 thrill_seeker = 1 sets: none gear: avowed_arcanists_staff = 1 chalice_nobles_signet = 1 court_of_harvesters_tabard = 1 essence_extractor = 1 faemoss_amice = 1 faemoss_bindings = 1 gorewrought_drape = 1 grimveiled_robe = 1 masque_of_the_path = 1 reinforced_high_collar = 1 sanctified_guardians_signet = 1 sincollectors_leggings = 1 slippers_of_the_leafy_undergrowth = 1 soulsiphoners_handwraps = 1 spine_crawler_waistcord = 1 vial_of_caustic_liquid = 1 legendaries: perpetual_agony_of_azjaqir = 1 itemIDs: 173241, 179282, 181177, 181179, 181218, 181224, 181334, 181420, 181426, 181503, 181638, 181702, 184127, 184133, 184729, 184755 settings: aoe = 3 buffPadding = 0.25 custom1Name = Custom 1 custom2Name = Custom 2 cycle = true cycle_min = 6 damage = true damageDots = true damageExpiration = 6 damagePets = false damageRange = 0 debuffPadding = 0.5 enabled = true enhancedRecheck = false gcdSync = true maxRefresh = 7 maxTime = 33 nameplateRange = 8 nameplates = false package = Affliction petbased = true potion = spectral_intellect potionsReset = 20180919.1 throttleRefresh = false throttleTime = false manage_ds_ticks = false toggles: cooldowns = true custom1 = false custom2 = false defensives = true [separate] essences = true interrupts = true [separate] mode = single potions = false ```

Please let me know if you need a snapshot or any other additional information.

– Tom

Hekili commented 3 years ago

Please provide a snapshot when you think you should be getting a CD recommendation but are not. See the new ticket instructions for details about snapshots.

tflo commented 3 years ago

Here you go:

While making the snapshot, the above mentioned error has not been logged, since I’m unable to reproduce it reliably. Though, the described recommendation anomalies (which might have a cause that is related to the cause of the error) were present.

Hekili commented 3 years ago

The error looked like it involved a multitarget scenario. You had two targets there, but maybe try 3+?

tflo commented 3 years ago

Ok, tried with the 5-target swarm dummy, and I can reliably produce the error then. Though, when the error is there, I cannot make snapshots. (Nothing saved and no snapshot confirmation in console; just the “There are too many errors in your UI.” message.)

Some interesting findings though: The error is triggered differently, depending if Phantom Singularity is selected or not:

With the 3-target cleave dummy the error does not appear.

Hekili commented 3 years ago

This is/was a silly typo error that I'm fixing right now.

tflo commented 3 years ago

Oh, glad to hear. Typos are the easiest ones :)

Hekili commented 3 years ago

This fix should be live. Reopen this ticket with new information if you still have the issue.

tflo commented 3 years ago

With which version has it gone live? I have 9.0.5-1.0.9a and cannot find anything newer.