HelloThisIsFlo / Appdaemon-Test-Framework

Clean, human-readable tests for Appdaemon
https://hellothisisflo.github.io/Appdaemon-Test-Framework/
MIT License
45 stars 19 forks source link

Deprecation of `hass_functions` #28

Closed HelloThisIsFlo closed 4 years ago

HelloThisIsFlo commented 4 years ago

Deprecation of hass_functions

Hi everyone,

To prepare for the addition of absolutely amazing features related to time-travel, worked on by @lifeisafractal, we are deprecating the direct use of hass_functions in favor of accessing them via HassMocks.

If you have any issues with the deprecation, please comment on this thread 🙂

Quick migration guide:

lifeisafractal commented 4 years ago

It's been a few months on this one and a few PRs have merged pushing things in this direction. Is now a good time to consider closing out this ticket?

HelloThisIsFlo commented 4 years ago

Oh yes. I think it was an issue that I raised after one of you PR where the migration away from the deprecated function wasn't clear. But in the meantime, if I remember correctly, you implemented a slightly different way and updated the readme. So this issue doesn't make sense anymore :) I'm closing