search

HelloThisIsFlo / Appdaemon-Test-Framework

Clean, human-readable tests for Appdaemon
https://hellothisisflo.github.io/Appdaemon-Test-Framework/
MIT License
45 stars 19 forks source link

Use setup.py as source of truth for deps #39

Closed HelloThisIsFlo closed 4 years ago

HelloThisIsFlo commented 4 years ago

After our discussion @lifeisafractal where you mentioned your process for creating the dev virtual env:

  1. Create a virtual env
  2. Install appdaemontestframework
  3. Start working

Step 2. is key because by installing appdaemontestframework directly in the local virtual env, it'll automatically install all the dependencies of the setup.py. So no need to replicate anything in the Pipfile

It seems almost too simple to work, but I can't seem to see any catch. It does work as expected locally. Let me know if you think it's good as well, and we can merge.

lifeisafractal commented 4 years ago

This looks great, glad we talk this out quickly.

My only question is if there should be a quick reference to using pipenv for devlopment in the README.md maybe in the Contributing section, or adding a Development section for this and future development details. Totally not required, just thinking about how I missed the whole pipenv thing at first when diving in.

Other than that, looks good to go from my point of view.

HelloThisIsFlo commented 4 years ago

Oh good point. I'll add that, 1 sec

HelloThisIsFlo commented 4 years ago

@lifeisafractal I just updated the README.

  1. Removed warning about tests being not reliable (it's not true anymore)
  2. Added a guide for Pipenv

If it's good . . . let this be the first PR you merge yourself 😊

HelloThisIsFlo commented 4 years ago

Then you can merge it 😁

HelloThisIsFlo commented 4 years ago

Wohoo 🎉 The first PR you merged. 🎉 Congrats 😃

lifeisafractal commented 4 years ago

Thanks! 🎉 🎉