search

Helly1206 / skin.xonfluence

eXtended MOD of Confluence skin
Other
27 stars 45 forks source link

SOFTEN - Bug #56

Open henryjfry opened 3 years ago

henryjfry commented 3 years ago

As per this issue for script.extendedinfo: https://github.com/a4k-openproject/script.extendedinfo/issues/4

This bug still appears to be an issue with various skins based on Aeon/Xonfluence?

I dont use either skin but have been updating script.extendedinfo and have had the issue reported to me.

I think its caused by "Default.xml" and ""

    <default type="radiobutton">
        <left>450</left>
        <top>300</top>
        <width>450</width>
        <height>63</height>
        <include condition="String.IsEmpty(Skin.String(LayoutLAF))">RadioButtonClassic</include>
        <include condition="!String.IsEmpty(Skin.String(LayoutLAF))">RadioButtonModern</include>
        <include>NormalButton</include>
        <label>215</label>
        <font>font13</font>
        <textcolor>white</textcolor>
        <disabledcolor>grey3</disabledcolor>
        <textoffsetx>10</textoffsetx>
        <aligny>center</aligny>
        <pulseonselect>no</pulseonselect>
    </default>

The skin has no strings.po number 215 so I think thats where it defaults back to "resource.language.en_gb" and "Soften" is returned.

henryjfry commented 3 years ago

I can report that removing the label reference to 215 does fix the random "Soften" which appears in extendedinfo when you are using Xonfluence:

<label></label>

However a better way to fix it (and not impact whatever that label is supposed to be for), might be a visible tag?

<visible>String.IsEmpty(Window.Property(movie.Plot)) + String.IsEmpty(Window.Property(tvshow.Plot)) + String.IsEmpty(Window.Property(episode.Plot))</visible>

??