HelpChat / ChatChat

ChatChat - Coming Soon
MIT License
52 stars 33 forks source link

Griefprevention softmute not working #211

Closed Smudgge closed 1 year ago

Smudgge commented 1 year ago
ChatChat: #65
Server Version: 1.19.4
Grief Prevention: 16.18.1

I had a look though the code but I could not find why the new grief prevention code is not working.

Same as before, when you softmute a player, players are still able to see what they are saying.

BlitzOffline commented 1 year ago

You have to go to plugins/ChatChat/extensions.yml and enable the griefprevention soft mute extension. Let me know if it still isn't working after that.

Smudgge commented 1 year ago
addons:
  deluxechat:
    inverse_priorities: true
    unicode_permission:
      public_chat: true
      private_chat: true
  towny:
    channels: false
  discordsrv:
    channels_bridging: false
  essentials:
    vanish: false
  supervanish:
    vanish: true
    soft_mute: false
  griefprevention:
    soft_mute: true

We have softmute set to true but still doesn't work.

Screenshot 2023-06-21 at 10 04 57 pm IMG-20230621-WA00032

BlitzOffline commented 1 year ago

Just making sure but have you restarted the server after toggling it to true? Any changes in extensions.yml require a restart to apply.

Smudgge commented 1 year ago

I think we have found the issue, when you reload the plugin the config regenerates like this :

addons:
  deluxechat:
    inverse_priorities: false
    unicode_permission:
      public_chat: true
      private_chat: true
  towny:
    channels: false
  discordsrv:
    channels_bridging: false
  essentials:
    vanish: false
  supervanish:
    vanish: false
    soft_mute: true

Maybe you could look though the code, may be related to why softmute is not working

Smudgge commented 1 year ago

Screenshot 2023-06-22 at 10 22 38 am Ahh found it!

Smudgge commented 1 year ago

Made fix here #212

BlitzOffline commented 1 year ago

Ah. Good catch. Tested everything but right before finishing that PR I've made some changes that I didn't test and I guess somehow I managed to forget to change something when copy pasting the changes.

BlitzOffline commented 1 year ago

Fixed in #212