Review

[weijia-cheng]

Style

• [x] book-1.xhtml: Instead of the comment <!--Missing chapter number: 44-->, we should just add the chapter number into the text as an editorial change.
• [x] endnotes.xhtml: Having the begin/end HTML comments isn’t called for by our code style, especially since that information can be deduced from looking at the backlink anchors.

Semantics

• [x] endnotes.xhtml: There is an instance of MSS. in note 539 that is not semanticated.
• [x] I would do a manual pass through the endnotes to look for more abbreviations that need semantics. For example P.-L. Courier should have abbreviation semantics for a person’s initials and some instances of cp. need an <abbr> tag.
• [x] 74f85e568a27f1f552d0d6dae72530685a29476d: I think there was some miscommunication here. Alex said that that units of measure at not italicized unless they are non-English words, and these are pretty much all non-English words. This should be reverted.
• [x] Some italics still lack semantics. Use grep --recursive --line-number "<i>" src/epub/text/*.xhtml to find them.

Spelling

• [x] The any one to anyone modernization was done too aggressively, namely anything that falls in the any one of [GROUP] pattern, e.g. when a man wishes to sa crifice to any one of the gods. Explanation here.
• [x] There is a similar issue with the some one to someone modernization with the some one of [GROUP] pattern, e.g. someone of those who serve him. Explanation here.
• [x] book-1.xhtml: praying forever since the time should be reverted back to praying for ever since the time—this was a mistake made while modernizing spelling.
• [x] mastich can be modernized to mastic.
• [x] In fed245fb28918c6db7666d3252553cf3a9c99686, you removed the grave accent from several instances of verse where they are being used for scansion. These grave accents should be restored.
• [x] d39a61e8d287bd33b57dfd4a1922db0d9ddb455d: I don’t think fluteplayer is a recognized English word, and in any case flute-player is more common based on Google Ngrams. We should standardize on flute-player instead.
• [x] 66c28c5b82fa12d62821cc6b0fa0e4dcf4cec7a1: Should be reverted, since this is not a sound-alike change and my understanding is that the version ending in -s is a transliteration of the original Greek word. The version with the -s dropped is specific to English.
• [x] 7dcaba774b8ea1799c04549308ca9ad5789f18f6: Not a sound-alike change.
• [x] 8afbffc1ac44733e83c581ebbf661ccaa1d524c6: Not a sound-alike change, and both versions are used in modern English.
• [x] f0339f079dedd5ecea2a97494faf0b6629f2473d: Isn’t Laius more common?
• [x] ec966f1852a157890bf3fc3a619cc6986c54b333: Revert since that is the proper French spelling.

Lint

• [x] t-057 should still be enforced.

Colophon

• [x] Instead of is thought to have been written by 430ñ<abbr epub:type="se:era">BC</abbr>, let’s use was published circa 430ñ<abbr epub:type="se:era">BCE</abbr>.

Metadata

• [x] dc:description should be a complete sentence.
• [x] I think the long description could use some revision. It is a little vague about the contents of the book, and I think it could use more elaboration on the book’s significance.
• [x] The first part of the production notes about <h3>s is outdated.

Meta

• [x] 0b01ca3a9086390d14363af7c0537afbc1bdf189: Mixes editorial changes with non-editorial typography changes.
• [x] 88e3aec5e04c910ad7fef73d11fefc8ddc880f69: Looks like an unrelated cover change is mixed into this for some reason.
• [x] 0ff0b0e817709e2c9830feed8b658e9488f0e665: Not a big deal, but there is a typo in the commit message (it should say Ichthyophagi).
• [x] d2e6ddd8b8caadf3429187d35611b9b8bd18b8d1: Commit message also has a typo.
• [x] cf4a469e097a5eafa69ef1491ad334caa9269088: Commit message doesn’t accurately describe the change.

[weijia-cheng]

Semantics

• [x] endnotes.xhtml: I still see an instance of P.-L. Courier that need semantics.
• [x] 992c571c9c99a35da13214653692f68af59562dc: The measurements are still non-English words, so they need to be italics with language semantics. Also I think san should be considered ancient Greek and given language semantics (sigma can be left as is since it is in Merriam-Webster).

Spelling

• [x] I think we can still do another commit modernizing Laios to Laius.