HenningM / express-ws

WebSocket endpoints for express applications
BSD 2-Clause "Simplified" License
877 stars 142 forks source link

Bumps ws to latest version and replaces babel for esm #102

Closed OmgImAlexis closed 6 years ago

OmgImAlexis commented 6 years ago

Since this doesn't include any tests I used the example/simple.js to verify it still works with the new version.

I've also replaced babel with esm in this meaning no more compiling just to add import/export support.

For now to use this run either of these and you'll be good to go.

$ npm install https://github.com/OmgImAlexis/express-ws
$ yarn add https://github.com/OmgImAlexis/express-ws

Replaces https://github.com/HenningM/express-ws/pull/95 Closes https://github.com/HenningM/express-ws/issues/90

OmgImAlexis commented 6 years ago

@HenningM any chance this could be reviewed soon?

OmgImAlexis commented 6 years ago

@HenningM could you please have a look at this.

OmgImAlexis commented 6 years ago

@HenningM sorry for the constantly pinging but this is something that's affecting me everyday at work.

As it seems you're still busy I'd like to offer taking over maintaining this for you until you're free enough to come back.

HenningM commented 6 years ago

Hi @OmgImAlexis,

First of all: my sincere apologies for not getting to this PR sooner. Unfortunately I haven't been able to give this project the attention it deserves lately. I'll do my best to improve the situation in the coming weeks and months, but I'm also open to the idea of inviting someone else to (co-)maintain this.

The changes in the PR look good to me at first glance, but I'll need to have a closer look before I can merge & release this. I'll get back to you tomorrow evening (UTC).

OmgImAlexis commented 6 years ago

No worries. Thanks for getting back to me.

OmgImAlexis commented 6 years ago

@HenningM would you mind publishing a new version to npm? The last published version is 5 months old.

safareli commented 3 years ago

@HenningM can you please publish new version on npm?