search

HenningM / express-ws

WebSocket endpoints for express applications
BSD 2-Clause "Simplified" License
877 stars 142 forks source link

include path incorrect in /index.js #148

Closed webarchymeta closed 3 years ago

webarchymeta commented 3 years ago

Version: 5.01 The current

./src/index

points to nowhere in the installed npm package ...

jasonolmstead33 commented 3 years ago

@webarchymeta @HenningM @OmgImAlexis Ive created a PR to revert the changes. seems as though this commit broke loading the /lib folder.

OmgImAlexis commented 3 years ago

@webarchymeta @HenningM @OmgImAlexis Ive created a PR to revert the changes. seems as though this commit broke loading the /lib folder.

Not sure why you opened that PR the revert doesn't need to happen. This is an issue on your end.

Can you show me the contents of node_modules/express-ws?

HenningM commented 3 years ago

I've published a 5.0.2 version without the babel -> esm changes for now. Let me know if this version works better for you, @webarchymeta.

I will have another look at your changes, @OmgImAlexis.

jasonolmstead33 commented 3 years ago

@HenningM thank you for that. seems to be working. will close the PR to revert changes.

webarchymeta commented 3 years ago

@HenningM it works for me now