search

HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
904 stars 757 forks source link

Skill rebalance from kro #3200

Open gbasso666 opened 1 year ago

gbasso666 commented 1 year ago

Implemented the skill changes from this patch: https://www.divine-pride.net/forum/index.php?/topic/3453-kro-mass-skills-balance-1st-2nd-and-transcendent-classes-skills/

All skills that were reworked were tested and seem to be working correctly. If I miss anything let me know

NOT IMPLEMENTED: -Basilica (completely new skill); -AMP (completely new skill); -Harmonic Lick (completely new skill); -Classical Pluck (todo: add CONFUSION to the aoe effect); -New Falcon Assault formula (IRO formula seems weird/wrong and I couldnt find another source).

Also, Bowling Bash should only have 4 hits on 4 or more targets with 2h sword. Atm I only implemented 4 hits with 2h sword at all instances (which I think it's fair).

Additional content: Some skill were later (2022) adjusted again in kro, I might have already updated them (like songs lasting 180sec).

PS: btw, Hindsight skill from Professor seems very convoluted on skill.c, large portions of code doesnt seem to do anything, I recommend someone clean it up.

MishimaHaruna commented 1 year ago

Hello, thank you for your contribution!

It would be nice if this was split into commits so that if in the future we'll need to debug an issue near the lines of code edited here, we'll be able to figure out if a change was intentional or accidental by reading the commit messages.

I'm scheduling this to be merged in the next release - I can lend a hand splitting this if you can't or don't know how

gbasso666 commented 1 year ago

Thanks Mishima, I've been terribly busy with work (and sick with covid also), also I'm not particularly good at github, so for now that's all I can contribute.