HerculesWS / Hercules

Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.
http://herc.ws
GNU General Public License v3.0
903 stars 758 forks source link

Validate length of configuration names from add*Conf HPM commands #3324

Closed guilherme-gm closed 1 month ago

guilherme-gm commented 2 months ago

Pull Request Prelude

Changes Proposed

Adds a validation when configuration registered by HPM are longer than the supported size.

Today it would silently fail because the registered key is shorter than the actual name, it would not work but also not alert because it simply didn't find and the defaults for add*Conf macros is to make them not required.

With this change, users would be informed that this configuration won't work so they can provide a shorter name or increase the define.

Issues addressed: None, I think