HermannBjorgvin / Kennitala

Icelandic national ID (kennitölur) utilities for servers and clients.
MIT License
36 stars 10 forks source link

Removing 20-99 check for persons, as gervimenn have lower values. #26

Closed saevarma closed 2 years ago

saevarma commented 2 years ago

What

Removing 7th and 8th number between 20-99 check in isPerson.

Why

This checks breaks validation for many Gervimenn registered in National Registry's database. Hey have 7th and 8th number values lower than 20.

As the usage of Gervimenn is getting used more for testing, specially related to GDPR, this package should support them and validate them correctly as persons.

saevarma commented 2 years ago

@HermannBjorgvin this is causing us some issues in the island.is repo. If you could look into this as soon as possible, it would be much appreciated 🙏

HermannBjorgvin commented 2 years ago

@saevarma I've tried before to find a list of Gervimenn and the rules for them. Could you provide some detail on how they work?

The merge looks good, will merge it into the next beta update and try to have it published today.

saevarma commented 2 years ago

@saevarma I've tried before to find a list of Gervimenn and the rules for them. Could you provide some detail on how they work?

The merge looks good, will merge it into the next beta update and try to have it published today.

Þjóðskrá have published this: https://opingogn.is/dataset/pjooskra-gervigogn

HermannBjorgvin commented 2 years ago

@saevarma I've tried before to find a list of Gervimenn and the rules for them. Could you provide some detail on how they work? The merge looks good, will merge it into the next beta update and try to have it published today.

Þjóðskrá have published this: https://opingogn.is/dataset/pjooskra-gervigogn

Thanks for that link! I remember searching for it sometime without any luck.

HermannBjorgvin commented 2 years ago

@saevarma here we have it https://www.npmjs.com/package/kennitala/v/2.0.0-beta.2

Thanks for the valuable contribution, very much appreciate it!

saevarma commented 2 years ago

@saevarma here we have it https://www.npmjs.com/package/kennitala/v/2.0.0-beta.2

Thanks for the valuable contribution, very much appreciate it!

Thank you! Keep up the good work 🙏