search

HeroGamers / MyDog

Tamed wolves but at least 10x better
https://www.spigotmc.org/resources/mydog.70260/
MIT License
11 stars 9 forks source link

Dog gets user prefix in nametag #109

Open Krazytrain opened 1 year ago

Krazytrain commented 1 year ago

Type of bug

Compatibility issue

Error log (if applicable)

No response

Bug description

The prefix of your nametag goes on the dogs nametag.

Steps to reproduce

  1. Have a prefix on your name with luckperms or nametagedit
  2. Your dog will have this prefix too.

Expected behaviour

Dog not to have the prefix in there name.

Actual behaviour

Dog namename has your prefix in there nametag too.

HeroGamers commented 1 year ago

Hi there,

Thanks for the bug report!

Can you let me know what your chat formatting plugin is? i.e. EssentialsChat, etc. Do you have any other plugins that might change the names of tameables?

I have had prefixes on multiple testing environments for MyDog and have never run into this issue - so I would need some more info to try and reproduce this issue.

For technicalities, the following is how custom names for dogs are made in MyDog (https://github.com/HeroGamers/MyDog/blob/master/src/main/java/dk/fido2603/mydog/objects/Dog.java#L461):

None of the code should use prefixes in any way, or have anything to do with the owner.

Could you provide more information, then I can try reproducing it again.

Cheers, Hero

Krazytrain commented 1 year ago

We have Essentials chat and Name tag edit plugin, we also use luck perms for the permissions.

Krazytrain commented 1 year ago

Looking into it tab has nametags too but we dont use them. We only use it for the tab lists

Krazytrain commented 1 year ago

So i have removed alot of the plugins and still happens...

Image

Nothing to do with luckperms too.

Krazytrain commented 1 year ago

Turns out it was TAB... Reading through there wiki i found this, Additional note 2 - Prefix/suffix on pets Since 1.9 teams affect tamed animals as well, displaying prefix/suffix on them as well and if unlimited nametag mode is enabled, they will be completely invisible. If you want to avoid it, install this plugin.

I had to add another plugin to remove the nametags on pets.

HeroGamers commented 1 year ago

Hi there!

Thanks so much for the extensive testing! In the next release, I'll reopen the issue and turn it into a feature to disable owner nametags on dogs, such that others don't have to go and install another plugin for a feature which I feel should also be implemented by MyDog.

Best regards, Hero

HeroGamers commented 1 year ago

Note for future: Probably requires NMS or ProtocolLib