HertzDevil / 0CC-FamiTracker

Extension of jsr's FamiTracker
http://0cc-famitracker.tumblr.com/
GNU General Public License v2.0
309 stars 32 forks source link

Crash when deleting N163 waveform after playing/previewing #61

Closed nyanpasu64 closed 7 years ago

nyanpasu64 commented 7 years ago

Windows 10 x64, 0CC 0.3.14.4.

So I just lost 7 hours of work to this crash... Apparently, deleting N163 instruments while they're in use, can crash the program.

To reproduce, open 0CC, enable N163 mode, and create a N163 instrument. If you preview the instrument using the virtual piano, then delete the instrument without first playing back the song first, the program will crash. The program also crashes if you play a song, and you delete the last instrument played in any channel.

I noticed that by enabling View/Register State, each row keeps cycling through values, even after you release a note on the virtual keyboard, or note-cut in a song. If you delete the instrument corresponding to any cycling row, the program crashes.

Example FTI (probably irrelevant)

nyanpasu64 commented 7 years ago

Does not appear to occur in Git Master 0CC-Famitracker. I tried Debug and Release x86, using Visual Studio 2015. Maybe the undefined memory bug is merely obscured...

nyanpasu64 commented 7 years ago

3.14.5 fixed