search

HexagonMC / BungeeCord

BungeeCord for Minecraft 1.7.10/1.8/1.9/1.10/1.11/1.12/1.13/1.14/1.15/1.16/1.17/1.18/1.19
Other
157 stars 66 forks source link

Use patch files instead of having the whole source #211

Closed DoNotSpamPls closed 6 years ago

DoNotSpamPls commented 6 years ago

This will make the modifications made by Hexacord a lot more maintainable (just look at Paper/Waterfall).

johnfriedrich commented 6 years ago

Hi, yes you could be right. But keep in mind we simply merge from upstream, no extra patches like Paper/Waterfall. Additionally our devs that maintained this fork quit developing for mc. They merge changes occasionally when I request it. They do not have time to setup patches initially, left alone applying further patches.

DoNotSpamPls commented 6 years ago

Well, you have done some modifications to the code to allow 1.7, so that could be converted to patch files in the future. Nobody is asking for new features. Also, you could have upstream as a submodule, it's way easier to update that

DoNotSpamPls commented 6 years ago

EDIT: I could try to convert it when I have free time, although it'd be nice if upstream was merged so 1.13 changes don't interfere. It would be much easier to differentiate the changes that way.

kjl13 commented 6 years ago

Can you please merge from upstream? @i9hdkill

sleiss commented 6 years ago

As @i9hdkill already mentioned, @Zartec and me, who patched HexaCord the most, don't activly develop for MC anymore. Therefor, at least from me, there won't be any "breaking changes" to HexaCord. If you provide the patches, we can look at them and maybe change the buildscript to use them, but at the moment, I don't have interest and time in doing this.

You can reopen the issue if you created the patches.

@kjl13 It's merged now.

DoNotSpamPls commented 6 years ago

@sleiss I made a repository (https://github.com/DoNotSpamPls/Hexacord) which includes a completely revamped process with patches, inspired by Waterfall's. I'd love it if you can check it out and decide if you want to add it. (i can't open the issue since you closed it btw)