search

Heyvaert / wiquery

Automatically exported from code.google.com/p/wiquery
0 stars 0 forks source link

Fix for #234 breaks resource management for core resources #248

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

This is a followup of our private discussion:

******
The commit 
https://github.com/WiQuery/wiquery/commit/281a0be3d7d11a4d1b92126fa455491e95c662
32
breaks our application because after this commit, the jquery core and
jquery ui resources are added directly to the underlying response and
they aren't managed by wiQuery anymore.

As we have declared by hand dependencies to Core and UI to better
track what we need for each component, it's important for our
application to keep them managed by wiQuery (and I think it's probably
what everyone would expect).

I know that I could disable AutoImportJQueryResource but it worked
perfectly until now and I'm wondering if some of the calls in this
commit shouldn't keep the wiquery decorated response, especially this
one:
// calling listeners to compute specific stuff
                       for (WiQueryPluginRenderingListener listener : pluginRenderingListeners)
                       {
                               listener.onRender(plugin, getRealResponse());
                       }
******

Thanks.

Original issue reported on code.google.com by guillaum...@gmail.com on 29 May 2012 at 8:12

GoogleCodeExporter commented 9 years ago 
The issue was either
-not reproducable
-there is a newer version available
-reported in a version which is no longer supported

if the issue is still present in the latest version (6.9+) then please reopen 
the issue with the required information to reproduce the issue.

Original comment by hielke.hoeve on 26 Nov 2013 at 8:37