MarkupIdVisitor forces children to be visited twice

[GoogleCodeExporter]

Hi,

I have identified a problem similar to 
http://code.google.com/p/wiquery/issues/detail?id=152 while using the 
SortableAjaxBehavior.

The call from line 396 in SortableAjaxBehavior: 

/* line :395*/MarkupIdVisitor visitor = new MarkupIdVisitor(input);
/* line :396*/this.getComponent().getPage().visitChildren(visitor);

takes a lot of time when I have a page with a deep hierarchy of containers.

Inspecting the MarkupIdVisitor class, it seems like the extra call is still 
there:

if (component instanceof MarkupContainer)
        {
            ((MarkupContainer) component).visitChildren(Component.class, this);
        }

The version of wiquery-core I'm using in my project is : wiquery-core-1.5.6.
In which version is this fixed? It seems that the trunk does still contain this 
line and the newest version of this file is from 22 September 2011.

Thanks,
Cristi

Original issue reported on code.google.com by cristi.c...@gmail.com on 1 Nov 2012 at 12:15

[GoogleCodeExporter]

fixed for master and wicket-15.

Original comment by hielke.hoeve on 9 Nov 2012 at 1:59

• Changed state: Fixed

[GoogleCodeExporter]

I have checked it again with wiquery-jquery-ui version 1.5.7 and wicket 1.5.7 
and it is not fixed. Running the attached application took on my machine almost 
8 seconds for the ajax call to complete. Can you please tell me on which 
version is it fixed? (The trunk contains the same version shown in my previous 
comment).  

Original comment by cristi.c...@gmail.com on 9 Nov 2012 at 3:38

Attachments:

• slowdroppable157.zip

[GoogleCodeExporter]

i have not released any artifacts yet. as you could have seen 1.5.7 was already 
released before my fix so 1.5.8 and 6.2.0 will have this fix...

note that we no longer use the svn repo from google but github: 
https://github.com/WiQuery/wiquery/

Original comment by hielke.hoeve on 9 Nov 2012 at 3:53