search

HiWord9 / RPRenames

Minecraft fabric mod RP Renames that shows u every possible textured CIT and CEM rename from ur resource packs.
https://modrinth.com/mod/rp-renames
21 stars 6 forks source link

Previewing the wrong texture with elytras #52

Closed gorkareplay closed 7 months ago

gorkareplay commented 7 months ago

My resource pack has two elytras, both have two textures, one for the broken version(damage = 431) and one for the non-broken one. When using this mod with my resource pack in the menu the preview for the elytra shows the broken version by default. Is there a way I can overwrite that?

HiWord9 commented 7 months ago

i would like to see the pack, please send it here

HiWord9 commented 7 months ago

Im pretty sure in ur case the menu should display both variant, the broken one and the one with full durability. The only thing i noticed that there wont be broken variant in menu if the property file for type=item specifies both texture.elytra=texture and texture.broken_elytra=broken_texture in one file

gorkareplay commented 7 months ago

Here is the resource pack PlayerThingsPaperBin.zip

HiWord9 commented 7 months ago

So i took a look at ur pack and found out what causes it. RPR wont add another rename to list if there is the same rename or same but with some values not assigned. In ur case u made one rename with damage=431 and another without damage property at all, rpr treats second one as already assigned and does not adds it to list.

There are a few ways to list the full durability rename:

  1. U can add to unbroken property file parameter damage=0-430, in this case both broken and unbroken variants will be treated as different renames. image

  2. U can make one property file for both broken and intact variants the way i described here, all u need is just to make two texture parameters in one property file, texture.elytra=texture and texture.broken_elytra=broken_texture, and u do not need damage anymore. This way is the best, as it is intended and there wont be broken variant in list, what i think better than seeing both. image image

Mb i could make feature where rename will tell if it has broken variant in tooltip in future, but it is not in plans and not neccessary for now. Hope i helped u with ur pack!