search

Hieromon / AutoConnect

An Arduino library for ESP8266/ESP32 WLAN configuration at runtime with the Web interface
https://hieromon.github.io/AutoConnect/
MIT License
889 stars 185 forks source link

Added text labels for Next/Prev. and in progress... #564

Closed faanskit closed 1 year ago

faanskit commented 1 year ago

Compiled and successfully tested on PlatformIO and ESP32 (AZ-Delivery-Devkit-v4)

Hieromon commented 1 year ago

@faanskit, Thank you for a PR. There was a change in the Ticker library in ESP8266 Arduino Core 3.1.1; it will not compile with AutoConnect v1.4.1. This is why your PR will have a build error on the ESP8266 and cannot be merged.

I have staged a patch to AutoConnect for ESP8266 core 3.1.1 that resolves the above compile error into the patche/553 branch. If you would like to include this PR in v142, could you please submit a PR based on the following commit? Perhaps you would find it easier to base it on the patch/553 branch.

https://github.com/Hieromon/AutoConnect/commit/193925b27df5ec121806ec7a93fe4958b3caf4db

Thank you for your contribution.

faanskit commented 1 year ago

I hope I did this right now.

Hieromon commented 1 year ago

@faanskit, Thank you!

It has merged and will be released in v1.4.2. I still have work to do to support ESP8266 core 3.1.1, so the release is expected after next week.